revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-12 18:02:40 +01:00
Code Issues Releases Wiki Activity

Fix feed query cursor-based pagination on 32-bit systems

Browse source 
Summary: Fixes T8503. On 32-bit systems, these 64-bit integers will be mangled by the '%d' conversion implied by the 'int' type.

Test Plan: Somewhat guessing here since I don't have a 32-bit system handy, but this strongly echoes similar issues in the past. Feed works fine locally. Looked at the generated queries.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8503

Differential Revision: https://secure.phabricator.com/D13250
This commit is contained in:
epriestley 2015-06-11 10:23:20 -07:00
parent 6d6211d441
commit c71873ed7b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/feed/query/PhabricatorFeedQuery.php
View file

@ -101,7 +101,7 @@ final class PhabricatorFeedQuery
'key' => array( 'key' => array(
'table' => $table, 'table' => $table,
'column' => 'chronologicalKey', 'column' => 'chronologicalKey',
'type' => 'int', 'type' => 'string',
'unique' => true, 'unique' => true,
), ),
); );