From c756bf3476175f4835490a2ee95a19d0c0662665 Mon Sep 17 00:00:00 2001 From: Austin McKinley Date: Mon, 21 Jan 2019 12:34:16 -0800 Subject: [PATCH] Fix bin/accountadmin when not making changes Summary: If you go through the `accountadmin` flow and change nothing, you get an exception about the transaction not having any effect. Instead, let the `applyTransactions` call continue even on no effect. Test Plan: Ran `accountadmin` without changing anything for an existing user. No longer got an exception about no-effect transactions. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D20009 --- scripts/user/account_admin.php | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/user/account_admin.php b/scripts/user/account_admin.php index 4ad722e125..4e4500a2f7 100755 --- a/scripts/user/account_admin.php +++ b/scripts/user/account_admin.php @@ -218,6 +218,7 @@ $user->openTransaction(); ->setActor($actor) ->setActingAsPHID($people_application_phid) ->setContentSource($content_source) + ->setContinueOnNoEffect(true) ->setContinueOnMissingFields(true); $transaction_editor->applyTransactions($user, $xactions);