revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 15:21:03 +01:00
Code Issues Releases Wiki Activity

Add some missing rendering code to textual feed stories

Browse source 
Summary: Ref T2852. Token given stories currently try to `strip_tags()` a `PHUIFeedView` or similar, which doesn't work. Cast it to a string before stripping. This is super gross but I don't want to clean it up until after ApplicationTransactions so we can really clean up all of Feed.

Test Plan: Ran `bin/feed republish <id>` on a feed story about giving a token to a revision.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6733
This commit is contained in:
epriestley 2013-08-13 10:11:47 -07:00
parent f11a4d5ef0
commit c7a84876c9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php
View file

@ -35,7 +35,7 @@ final class PhabricatorTokenGivenFeedStory
public function renderText() {
// TODO: This is grotesque; the feed notification handler relies on it.
return strip_tags($this->renderView()->render());
return strip_tags(hsprintf('%s', $this->renderView()->render()));
}
}

2
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
View file

@ -57,7 +57,7 @@ class PhabricatorApplicationTransactionFeedStory
public function renderText() {
// TODO: This is grotesque; the feed notification handler relies on it.
return strip_tags($this->renderView()->render());
return strip_tags(hsprintf('%s', $this->renderView()->render()));
}
}