Diffusion: rough cut of history view

Summary:
Very very rough approximation of history view. I left out all the
log parsing stuff for now since we should be able to just look it up in
a Repository table and I think that'll be a bit faster, although we can
muck around and see.

Test Plan:
Looked at history of a path

Reviewed By: jwilson
Reviewers: aran, jwilson
CC: epriestley, jwilson
Differential Revision: 66

src/__phutil_library_map__.php

@@ -151,8 +151,13 @@ phutil_register_library_map(array(
     'DiffusionFileContentQuery' => 'applications/diffusion/query/filecontent/base',
     'DiffusionGitBrowseQuery' => 'applications/diffusion/query/browse/git',
     'DiffusionGitFileContentQuery' => 'applications/diffusion/query/filecontent/git',
+    'DiffusionGitHistoryQuery' => 'applications/diffusion/query/history/git',
     'DiffusionGitRequest' => 'applications/diffusion/request/git',
+    'DiffusionHistoryController' => 'applications/diffusion/controller/history',
+    'DiffusionHistoryQuery' => 'applications/diffusion/query/history/base',
+    'DiffusionHistoryTableView' => 'applications/diffusion/view/historytable',
     'DiffusionHomeController' => 'applications/diffusion/controller/home',
+    'DiffusionPathChange' => 'applications/diffusion/data/pathchange',
     'DiffusionRepositoryPath' => 'applications/diffusion/data/repositorypath',
     'DiffusionRequest' => 'applications/diffusion/request/base',
     'Javelin' => 'infrastructure/javelin/api',
@@ -439,7 +444,10 @@ phutil_register_library_map(array(
     'DiffusionController' => 'PhabricatorController',
     'DiffusionGitBrowseQuery' => 'DiffusionBrowseQuery',
     'DiffusionGitFileContentQuery' => 'DiffusionFileContentQuery',
+    'DiffusionGitHistoryQuery' => 'DiffusionHistoryQuery',
     'DiffusionGitRequest' => 'DiffusionRequest',
+    'DiffusionHistoryController' => 'DiffusionController',
+    'DiffusionHistoryTableView' => 'AphrontView',
     'DiffusionHomeController' => 'DiffusionController',
     'ManiphestController' => 'PhabricatorController',
     'ManiphestDAO' => 'PhabricatorLiskDAO',

src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php

@@ -185,11 +185,19 @@ class AphrontDefaultApplicationConfiguration
 
       '/diffusion/' => array(
         '$' => 'DiffusionHomeController',
-        '(?P<callsign>[A-Z]+)/browse/'.
+        '(?P<callsign>[A-Z]+)' => array(
-          '(?P<path>.*?)'.
+          '/history/'.
-          '(?:[;](?P<commit>[a-z0-9]+))?'.
+            '(?P<path>.*?)'.
-          '(?:[$](?P<line>\d+))?$'
+            '(?:[;](?P<commit>[a-z0-9]+))?'.
-            => 'DiffusionBrowseController',
+            '$'
+              => 'DiffusionHistoryController',
+          '/browse/'.
+            '(?P<path>.*?)'.
+            '(?:[;](?P<commit>[a-z0-9]+))?'.
+            '(?:[$](?P<line>\d+))?'.
+            '$'
+              => 'DiffusionBrowseController',
+        ),
       ),
 
     );

src/applications/diffusion/controller/base/DiffusionController.php

@@ -18,6 +18,18 @@
 
 abstract class DiffusionController extends PhabricatorController {
 
+  protected $diffusionRequest;
+
+  public function willProcessRequest(array $data) {
+    $this->diffusionRequest = DiffusionRequest::newFromAphrontRequestDictionary(
+      $data);
+  }
+
+  public function setDiffusionRequest(DiffusionRequest $request) {
+    $this->diffusionRequest = $request;
+    return $this;
+  }
+
   public function buildStandardPageResponse($view, array $data) {
 
     $page = $this->buildStandardPageView();

src/applications/diffusion/controller/base/__init__.php

@@ -8,6 +8,7 @@
 
 phutil_require_module('phabricator', 'aphront/response/webpage');
 phutil_require_module('phabricator', 'applications/base/controller/base');
+phutil_require_module('phabricator', 'applications/diffusion/request/base');
 
 phutil_require_module('phutil', 'utils');
 

src/applications/diffusion/controller/browse/DiffusionBrowseController.php

@@ -18,11 +18,6 @@
 
 class DiffusionBrowseController extends DiffusionController {
 
-  public function willProcessRequest(array $data) {
-    $this->diffusionRequest = DiffusionRequest::newFromAphrontRequestDictionary(
-      $data);
-  }
-
   public function processRequest() {
     $drequest = $this->diffusionRequest;
 

src/applications/diffusion/controller/browse/__init__.php

@@ -9,7 +9,6 @@
 phutil_require_module('phabricator', 'applications/diffusion/controller/base');
 phutil_require_module('phabricator', 'applications/diffusion/controller/file');
 phutil_require_module('phabricator', 'applications/diffusion/query/browse/base');
-phutil_require_module('phabricator', 'applications/diffusion/request/base');
 phutil_require_module('phabricator', 'applications/diffusion/view/browsetable');
 phutil_require_module('phabricator', 'view/form/error');
 phutil_require_module('phabricator', 'view/layout/panel');

src/applications/diffusion/controller/file/DiffusionBrowseFileController.php

@@ -18,13 +18,6 @@
 
 class DiffusionBrowseFileController extends DiffusionController {
 
-  private $diffusionRequest;
-
-  public function setDiffusionRequest(DiffusionRequest $request) {
-    $this->diffusionRequest = $request;
-    return $this;
-  }
-
   public function processRequest() {
     $file_query = DiffusionFileContentQuery::newFromDiffusionRequest(
       $this->diffusionRequest);

src/applications/diffusion/controller/history/DiffusionHistoryController.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class DiffusionHistoryController extends DiffusionController {
+
+  public function processRequest() {
+    $drequest = $this->diffusionRequest;
+
+    $history_query = DiffusionHistoryQuery::newFromDiffusionRequest(
+      $drequest);
+
+    $history = $history_query->loadHistory();
+
+    $content = array();
+
+    $history_table = new DiffusionHistoryTableView();
+    $history_table->setDiffusionRequest($drequest);
+    $history_table->setHistory($history);
+
+    $history_panel = new AphrontPanelView();
+    $history_panel->setHeader($drequest->getPath());
+    $history_panel->appendChild($history_table);
+
+    $content[] = $history_panel;
+
+    // TODO: Crumbs
+    // TODO: Side nav
+
+    return $this->buildStandardPageResponse(
+      $content,
+      array(
+        'title' => 'history',
+      ));
+  }
+
+}

src/applications/diffusion/controller/history/__init__.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/diffusion/controller/base');
+phutil_require_module('phabricator', 'applications/diffusion/query/history/base');
+phutil_require_module('phabricator', 'applications/diffusion/view/historytable');
+phutil_require_module('phabricator', 'view/layout/panel');
+
+
+phutil_require_source('DiffusionHistoryController.php');

src/applications/diffusion/data/pathchange/DiffusionPathChange.php

@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+final class DiffusionPathChange {
+
+  private $commit;
+
+  final public function setCommit($commit) {
+    $this->commit = $commit;
+    return $this;
+  }
+
+  final public function getCommit() {
+    return $this->commit;
+  }
+
+
+}

src/applications/diffusion/data/pathchange/__init__.php

@@ -0,0 +1,10 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+
+phutil_require_source('DiffusionPathChange.php');

src/applications/diffusion/query/history/base/DiffusionHistoryQuery.php

@@ -0,0 +1,57 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+abstract class DiffusionHistoryQuery {
+
+  private $request;
+
+  final private function __construct() {
+    // <private>
+  }
+
+  final public static function newFromDiffusionRequest(
+    DiffusionRequest $request) {
+
+    $repository = $request->getRepository();
+
+    switch ($repository->getVersionControlSystem()) {
+      case 'git':
+        $class = 'DiffusionGitHistoryQuery';
+        break;
+      default:
+        throw new Exception("Unsupported VCS!");
+    }
+
+    PhutilSymbolLoader::loadClass($class);
+    $query = new $class();
+
+    $query->request = $request;
+
+    return $query;
+  }
+
+  final protected function getRequest() {
+    return $this->request;
+  }
+
+  final public function loadHistory() {
+    return $this->executeQuery();
+  }
+
+  abstract protected function executeQuery();
+}

src/applications/diffusion/query/history/base/__init__.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phutil', 'symbols');
+
+
+phutil_require_source('DiffusionHistoryQuery.php');

src/applications/diffusion/query/history/git/DiffusionGitHistoryQuery.php

@@ -0,0 +1,66 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+final class DiffusionGitHistoryQuery extends DiffusionHistoryQuery {
+
+  protected function executeQuery() {
+    $drequest = $this->getRequest();
+
+    $repository = $drequest->getRepository();
+    $path = $drequest->getPath();
+    $commit = $drequest->getCommit();
+
+    $local_path = $repository->getDetail('local-path');
+    $git = $drequest->getPathToGitBinary();
+
+    list($stdout) = execx(
+      '(cd %s && %s log '.
+        '-n %d '.
+        '--skip=%d '.
+        '-M '.
+        '-C '.
+        '-B '.
+        '--find-copies-harder '.
+        '--raw '.
+        '-t '.
+        '--abbrev=40 '.
+        '--pretty=format:%%x1c%%H%%x1d '.
+        '%s -- %s)',
+      $local_path,
+      $git,
+      $limit = 100,
+      $offset = 0,
+      $commit,
+      $path);
+
+    $commits = explode("\x1c", $stdout);
+    array_shift($commits); // \x1c character is first, remove empty record
+
+    $history = array();
+    foreach ($commits as $commit) {
+      list($hash, $raw) = explode("\x1d", $commit);
+
+      $item = new DiffusionPathChange();
+      $item->setCommit($hash);
+      $history[] = $item;
+    }
+
+    return $history;
+  }
+
+}

src/applications/diffusion/query/history/git/__init__.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/diffusion/data/pathchange');
+phutil_require_module('phabricator', 'applications/diffusion/query/history/base');
+
+phutil_require_module('phutil', 'future/exec');
+
+
+phutil_require_source('DiffusionGitHistoryQuery.php');

src/applications/diffusion/request/git/DiffusionGitRequest.php

@@ -38,6 +38,7 @@ class DiffusionGitRequest extends DiffusionRequest {
       // here than to try to do it in every query.
 
       $branch = $this->getBranch();
+
       execx(
         '(cd %s && %s rev-parse --verify %s)',
         $local_path,

src/applications/diffusion/view/browsetable/DiffusionBrowseTableView.php

@@ -19,6 +19,7 @@
 final class DiffusionBrowseTableView extends AphrontView {
 
   private $request;
+  private $paths;
 
   public function setDiffusionRequest(DiffusionRequest $request) {
     $this->request = $request;

src/applications/diffusion/view/historytable/DiffusionHistoryTableView.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+final class DiffusionHistoryTableView extends AphrontView {
+
+  private $request;
+  private $history;
+
+  public function setDiffusionRequest(DiffusionRequest $request) {
+    $this->request = $request;
+    return $this;
+  }
+
+  public function setHistory(array $history) {
+    $this->history = $history;
+    return $this;
+  }
+
+  public function render() {
+    $rows = array();
+    foreach ($this->history as $history) {
+      $rows[] = array(
+        phutil_escape_html($history->getCommit()), // TODO: link
+        // TODO: etc etc
+      );
+    }
+
+    $view = new AphrontTableView($rows);
+    $view->setHeaders(
+      array(
+        'Commit',
+      ));
+    return $view->render();
+  }
+
+}

src/applications/diffusion/view/historytable/__init__.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'view/base');
+phutil_require_module('phabricator', 'view/control/table');
+
+phutil_require_module('phutil', 'markup');
+
+
+phutil_require_source('DiffusionHistoryTableView.php');