From c85d6d5e1b916b05540283917bf61143931a7066 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 23 Jul 2012 12:49:43 -0700 Subject: [PATCH] Fix Diffusion fatal with symbol highlighting Summary: This returns a list of PHIDs, not objects which need to be pulled. Test Plan: Repro'd fatal locally, verified it was fixed. Repro steps are: - Create an arc project associated with a repository, with indexed language(s) and subprojects. - View a file in that repository. Reviewers: nh, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3038 --- .../diffusion/controller/DiffusionBrowseFileController.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php index 63d3a39caf..d88bad10b5 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -220,7 +220,6 @@ final class DiffusionBrowseFileController extends DiffusionController { continue; } $dep_projects = $project->getSymbolIndexProjects(); - $dep_projects = mpull($dep_projects, 'getPHID'); $dep_projects[] = $project->getPHID(); foreach ($ls as $lang) { if (!isset($langs[$lang])) {