From c978fe5240fef1840b46a283382e93cca6b54417 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 22 Nov 2013 16:31:14 -0800 Subject: [PATCH] Fix an issue where SSH protocols would check legacy credentials Missed this while grepping. We should use SSH purely based on protocol. Auditors: btrahan --- .../repository/storage/PhabricatorRepository.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index 40665be51a..0591f29958 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -660,11 +660,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO $protocol = $this->getRemoteProtocol(); if ($this->isSSHProtocol($protocol)) { - $key = $this->getDetail('ssh-key'); - $keyfile = $this->getDetail('ssh-keyfile'); - if ($key || $keyfile) { - return true; - } + return true; } return false;