1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00

Fix transcription of single-value bulk edit fields ("Assign to")

Summary: See PHI333. Some of the cleanup at the tail end of the bulk edit changes made "Assign To" stop working properly, since we don't strip the `array(...)` off the `array(PHID)` value we receive.

Test Plan:
  - Used bulk editor to assign and unassign tasks (single value datasource).
  - Used bulk editor to change projects (multi-value datasource).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18975
This commit is contained in:
epriestley 2018-01-31 10:37:38 -08:00
parent 1e3d1271ad
commit c9df8f77c8
3 changed files with 19 additions and 7 deletions

View file

@ -532,7 +532,7 @@ return array(
'rsrc/js/phuix/PHUIXButtonView.js' => '8a91e1ac',
'rsrc/js/phuix/PHUIXDropdownMenu.js' => '04b2ae03',
'rsrc/js/phuix/PHUIXExample.js' => '68af71ca',
'rsrc/js/phuix/PHUIXFormControl.js' => '1dd0870c',
'rsrc/js/phuix/PHUIXFormControl.js' => '16ad6224',
'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b',
),
'symbols' => array(
@ -884,7 +884,7 @@ return array(
'phuix-autocomplete' => 'e0731603',
'phuix-button-view' => '8a91e1ac',
'phuix-dropdown-menu' => '04b2ae03',
'phuix-form-control-view' => '1dd0870c',
'phuix-form-control-view' => '16ad6224',
'phuix-icon-view' => 'bff6884b',
'policy-css' => '957ea14c',
'policy-edit-css' => '815c66f7',
@ -995,6 +995,10 @@ return array(
'aphront-typeahead-control-css',
'phui-tag-view-css',
),
'16ad6224' => array(
'javelin-install',
'javelin-dom',
),
'17bb8539' => array(
'javelin-behavior',
'javelin-stratcom',
@ -1029,10 +1033,6 @@ return array(
'javelin-request',
'javelin-uri',
),
'1dd0870c' => array(
'javelin-install',
'javelin-dom',
),
'1e911d0f' => array(
'javelin-stratcom',
'javelin-request',

View file

@ -55,4 +55,16 @@ abstract class PhabricatorPHIDListEditType
}
}
public function getTransactionValueFromBulkEdit($value) {
if (!$this->getIsSingleValue()) {
return $value;
}
if ($value) {
return head($value);
}
return null;
}
}

View file

@ -293,7 +293,7 @@ JX.install('PHUIXFormControl', {
},
_newPoints: function(spec) {
return this._newText();
return this._newText(spec);
},
_newText: function(spec) {