Rename XHPAST database

Summary: Rename the XHPAST database from `{$NAMESPACE}_xpastview` to `{$NAMESPACE}_xhpast`.

Test Plan: Ran `./bin/storage --namespace test upgrade --no-quickstart`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14442

resources/sql/autopatches/20151109.xhpast.db.1.sql

@@ -0,0 +1,2 @@
+RENAME TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree
+  TO {$NAMESPACE}_xhpast.xhpast_parsetree;

resources/sql/autopatches/20151109.xhpast.db.2.sql

@@ -0,0 +1 @@
+DROP DATABASE {$NAMESPACE}_xhpastview;

src/__phutil_library_map__.php

@@ -3245,13 +3245,13 @@ phutil_register_library_map(array(
     'PhabricatorWorkingCopyDiscoveryTestCase' => 'applications/repository/engine/__tests__/PhabricatorWorkingCopyDiscoveryTestCase.php',
     'PhabricatorWorkingCopyPullTestCase' => 'applications/repository/engine/__tests__/PhabricatorWorkingCopyPullTestCase.php',
     'PhabricatorWorkingCopyTestCase' => 'applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php',
+    'PhabricatorXHPASTDAO' => 'applications/phpast/storage/PhabricatorXHPASTDAO.php',
+    'PhabricatorXHPASTParseTree' => 'applications/phpast/storage/PhabricatorXHPASTParseTree.php',
     'PhabricatorXHPASTViewController' => 'applications/phpast/controller/PhabricatorXHPASTViewController.php',
-    'PhabricatorXHPASTViewDAO' => 'applications/phpast/storage/PhabricatorXHPASTViewDAO.php',
     'PhabricatorXHPASTViewFrameController' => 'applications/phpast/controller/PhabricatorXHPASTViewFrameController.php',
     'PhabricatorXHPASTViewFramesetController' => 'applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php',
     'PhabricatorXHPASTViewInputController' => 'applications/phpast/controller/PhabricatorXHPASTViewInputController.php',
     'PhabricatorXHPASTViewPanelController' => 'applications/phpast/controller/PhabricatorXHPASTViewPanelController.php',
-    'PhabricatorXHPASTViewParseTree' => 'applications/phpast/storage/PhabricatorXHPASTViewParseTree.php',
     'PhabricatorXHPASTViewRunController' => 'applications/phpast/controller/PhabricatorXHPASTViewRunController.php',
     'PhabricatorXHPASTViewStreamController' => 'applications/phpast/controller/PhabricatorXHPASTViewStreamController.php',
     'PhabricatorXHPASTViewTreeController' => 'applications/phpast/controller/PhabricatorXHPASTViewTreeController.php',
@@ -7534,13 +7534,13 @@ phutil_register_library_map(array(
     'PhabricatorWorkingCopyDiscoveryTestCase' => 'PhabricatorWorkingCopyTestCase',
     'PhabricatorWorkingCopyPullTestCase' => 'PhabricatorWorkingCopyTestCase',
     'PhabricatorWorkingCopyTestCase' => 'PhabricatorTestCase',
+    'PhabricatorXHPASTDAO' => 'PhabricatorLiskDAO',
+    'PhabricatorXHPASTParseTree' => 'PhabricatorXHPASTDAO',
     'PhabricatorXHPASTViewController' => 'PhabricatorController',
-    'PhabricatorXHPASTViewDAO' => 'PhabricatorLiskDAO',
     'PhabricatorXHPASTViewFrameController' => 'PhabricatorXHPASTViewController',
     'PhabricatorXHPASTViewFramesetController' => 'PhabricatorXHPASTViewController',
     'PhabricatorXHPASTViewInputController' => 'PhabricatorXHPASTViewPanelController',
     'PhabricatorXHPASTViewPanelController' => 'PhabricatorXHPASTViewController',
-    'PhabricatorXHPASTViewParseTree' => 'PhabricatorXHPASTViewDAO',
     'PhabricatorXHPASTViewRunController' => 'PhabricatorXHPASTViewController',
     'PhabricatorXHPASTViewStreamController' => 'PhabricatorXHPASTViewPanelController',
     'PhabricatorXHPASTViewTreeController' => 'PhabricatorXHPASTViewPanelController',

src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php

@@ -12,7 +12,7 @@ abstract class PhabricatorXHPASTViewPanelController
 
   public function willProcessRequest(array $data) {
     $this->id = $data['id'];
-    $this->storageTree = id(new PhabricatorXHPASTViewParseTree())
+    $this->storageTree = id(new PhabricatorXHPASTParseTree())
       ->load($this->id);
 
     if (!$this->storageTree) {

src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php

@@ -21,7 +21,7 @@ final class PhabricatorXHPASTViewRunController
 
       list($err, $stdout, $stderr) = $resolved;
 
-      $storage_tree = id(new PhabricatorXHPASTViewParseTree())
+      $storage_tree = id(new PhabricatorXHPASTParseTree())
         ->setInput($source)
         ->setReturnCode($err)
         ->setStdout($stdout)

src/applications/phpast/storage/PhabricatorXHPASTDAO.php

@@ -0,0 +1,8 @@
+<?php
+
+abstract class PhabricatorXHPASTDAO extends PhabricatorLiskDAO {
+
+  public function getApplicationName() {
+    return 'xhpast';
+  }
+}

src/applications/phpast/storage/PhabricatorXHPASTParseTree.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorXHPASTViewParseTree extends PhabricatorXHPASTViewDAO {
+final class PhabricatorXHPASTParseTree extends PhabricatorXHPASTDAO {
 
   protected $authorPHID;
   protected $input;

src/applications/phpast/storage/PhabricatorXHPASTViewDAO.php

@@ -1,8 +0,0 @@
-<?php
-
-abstract class PhabricatorXHPASTViewDAO extends PhabricatorLiskDAO {
-
-  public function getApplicationName() {
-    return 'xhpastview';
-  }
-}

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

@@ -79,7 +79,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList {
       ),
       'db.user' => array(),
       'db.worker' => array(),
-      'db.xhpastview' => array(),
+      'db.xhpast' => array(),
+      'db.xhpastview' => array(
+        'dead' => true,
+      ),
       'db.cache' => array(),
       'db.fact' => array(),
       'db.ponder' => array(),