From ca50f8e9efb3f2afee7abb2e363ac26f42b5a77d Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 28 May 2015 11:32:17 -0700 Subject: [PATCH] [Redesign] Fix filetree view in Differential Summary: Ref T8099. We removed the background column, so this JS wasn't able to fire and make the filetree movable. Test Plan: Set Filetree on, resize it. Scroll through a diff. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13048 --- resources/celerity/map.php | 26 +++++++++---------- .../rsrc/js/core/behavior-phabricator-nav.js | 8 ------ 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index a0482eaf84..dea5d87c9d 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -8,7 +8,7 @@ return array( 'names' => array( 'core.pkg.css' => '75121d30', - 'core.pkg.js' => '9db3e620', + 'core.pkg.js' => 'e4f47dfd', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'bb338e4b', 'differential.pkg.js' => '63a77807', @@ -451,7 +451,7 @@ return array( 'rsrc/js/core/behavior-more.js' => 'a80d0378', 'rsrc/js/core/behavior-object-selector.js' => '49b73b36', 'rsrc/js/core/behavior-oncopy.js' => '2926fff2', - 'rsrc/js/core/behavior-phabricator-nav.js' => '14d7a8b8', + 'rsrc/js/core/behavior-phabricator-nav.js' => '56a1ca03', 'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'e32d14ab', 'rsrc/js/core/behavior-refresh-csrf.js' => '7814b593', 'rsrc/js/core/behavior-remarkup-preview.js' => 'f7379f45', @@ -597,7 +597,7 @@ return array( 'javelin-behavior-phabricator-keyboard-pager' => 'a8da01f0', 'javelin-behavior-phabricator-keyboard-shortcuts' => 'd75709e6', 'javelin-behavior-phabricator-line-linker' => '1499a8cb', - 'javelin-behavior-phabricator-nav' => '14d7a8b8', + 'javelin-behavior-phabricator-nav' => '56a1ca03', 'javelin-behavior-phabricator-notification-example' => '8ce821c5', 'javelin-behavior-phabricator-object-selector' => '49b73b36', 'javelin-behavior-phabricator-oncopy' => '2926fff2', @@ -913,16 +913,6 @@ return array( 'javelin-request', 'javelin-uri', ), - '14d7a8b8' => array( - 'javelin-behavior', - 'javelin-behavior-device', - 'javelin-stratcom', - 'javelin-dom', - 'javelin-magical-init', - 'javelin-vector', - 'javelin-request', - 'javelin-util', - ), '16c695bf' => array( 'javelin-behavior', 'javelin-dom', @@ -1192,6 +1182,16 @@ return array( 'javelin-vector', 'javelin-dom', ), + '56a1ca03' => array( + 'javelin-behavior', + 'javelin-behavior-device', + 'javelin-stratcom', + 'javelin-dom', + 'javelin-magical-init', + 'javelin-vector', + 'javelin-request', + 'javelin-util', + ), 58562350 => array( 'javelin-dom', 'javelin-util', diff --git a/webroot/rsrc/js/core/behavior-phabricator-nav.js b/webroot/rsrc/js/core/behavior-phabricator-nav.js index 6ff22b4212..d148558b1e 100644 --- a/webroot/rsrc/js/core/behavior-phabricator-nav.js +++ b/webroot/rsrc/js/core/behavior-phabricator-nav.js @@ -17,7 +17,6 @@ JX.behavior('phabricator-nav', function(config) { var local = JX.$(config.localID); var main = JX.$(config.mainID); var drag = JX.$(config.dragID); - var background = JX.$(config.backgroundID); // - Flexible Navigation Column ------------------------------------------------ @@ -44,12 +43,6 @@ JX.behavior('phabricator-nav', function(config) { width: JX.Vector.getDim(local).x, minWidth: 1 }, - { - element: background, - parameter: 'width', - start: JX.Vector.getDim(background).x, - minWidth: 1 - }, { element: drag, parameter: 'left', @@ -106,7 +99,6 @@ JX.behavior('phabricator-nav', function(config) { function resetdrag() { local.style.width = ''; - background.style.width = ''; drag.style.left = ''; content.style.marginLeft = ''; }