From ca618a86794f5d3b7df737a6c096bfbad8501b3e Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 24 Aug 2018 08:04:46 -0700 Subject: [PATCH] Document that `phd.taskmasters` is a local setting, per daemon Summary: Ref T13187. See PHI807. The documentation currently does not make it very clear that this is a local setting, per `phd` process. Make it more clear. Test Plan: {F5827757} Reviewers: amckinley Maniphest Tasks: T13187 Differential Revision: https://secure.phabricator.com/D19597 --- .../config/option/PhabricatorPHDConfigOptions.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/applications/config/option/PhabricatorPHDConfigOptions.php b/src/applications/config/option/PhabricatorPHDConfigOptions.php index bfe7c148c4..37fae45dfb 100644 --- a/src/applications/config/option/PhabricatorPHDConfigOptions.php +++ b/src/applications/config/option/PhabricatorPHDConfigOptions.php @@ -34,9 +34,14 @@ final class PhabricatorPHDConfigOptions ->setSummary(pht('Maximum taskmaster daemon pool size.')) ->setDescription( pht( - 'Maximum number of taskmaster daemons to run at once. Raising '. - 'this can increase the maximum throughput of the task queue. The '. - 'pool will automatically scale down when unutilized.')), + "Maximum number of taskmaster daemons to run at once. Raising ". + "this can increase the maximum throughput of the task queue. The ". + "pool will automatically scale down when unutilized.". + "\n\n". + "If you are running a cluster, this limit applies separately ". + "to each instance of `phd`. For example, if this limit is set ". + "to `4` and you have three hosts running daemons, the effective ". + "global limit will be 12.")), $this->newOption('phd.verbose', 'bool', false) ->setLocked(true) ->setBoolOptions(