mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Fix Releeph project creation crumb generation
Summary: Ref T3657. We currently try to generate a project crumb on the "Create Project" page, but fail. Paper that over until I can sort out T3657. Test Plan: Loaded project create page. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3657 Differential Revision: https://secure.phabricator.com/D6793
This commit is contained in:
parent
7a24548a3c
commit
ca6f13d90c
1 changed files with 15 additions and 8 deletions
|
@ -127,14 +127,21 @@ abstract class ReleephProjectController extends ReleephController {
|
|||
protected function buildApplicationCrumbs() {
|
||||
$crumbs = parent::buildApplicationCrumbs();
|
||||
|
||||
$project = $this->getReleephProject();
|
||||
$project_id = $project->getID();
|
||||
$project_uri = $this->getApplicationURI("project/{$project_id}/");
|
||||
// TODO: The massive amount of derps here should be fixed once URIs get
|
||||
// sorted out; see T3657.
|
||||
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setHref($project_uri)
|
||||
->setName($project->getName()));
|
||||
try {
|
||||
$project = $this->getReleephProject();
|
||||
$project_id = $project->getID();
|
||||
$project_uri = $this->getApplicationURI("project/{$project_id}/");
|
||||
|
||||
$crumbs->addCrumb(
|
||||
id(new PhabricatorCrumbView())
|
||||
->setHref($project_uri)
|
||||
->setName($project->getName()));
|
||||
} catch (Exception $ex) {
|
||||
// TODO: This is derps.
|
||||
}
|
||||
|
||||
try {
|
||||
$branch = $this->getReleephBranch();
|
||||
|
@ -144,7 +151,7 @@ abstract class ReleephProjectController extends ReleephController {
|
|||
->setHref($branch_uri)
|
||||
->setName($branch->getDisplayNameWithDetail()));
|
||||
} catch (Exception $ex) {
|
||||
// TODO: This is kind of derps.
|
||||
// TODO: This is also derps.
|
||||
}
|
||||
|
||||
return $crumbs;
|
||||
|
|
Loading…
Reference in a new issue