revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-02 02:40:58 +01:00
Code Issues Releases Wiki Activity

Fix an issue where email is overquoted when attaching objects

Browse source 
Summary:
Currently, if you attach a revision to a task and the revision has a title with quotes or angle brackets in it, they are over-escaped in the email.

Instead, don't do that.

Test Plan: Attached `"QUOTES" MATH: 1 < 2` to a task, got a reasonable looking email.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7186
This commit is contained in:
epriestley 2013-10-01 09:37:18 -07:00
parent 98bf001a58
commit ca85c457eb
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -190,7 +190,7 @@ abstract class PhabricatorApplicationTransaction
if ($this->renderingTarget == self::TARGET_HTML) { if ($this->renderingTarget == self::TARGET_HTML) {
return $this->getHandle($phid)->renderLink(); return $this->getHandle($phid)->renderLink();
} else { } else {
return hsprintf('%s', $this->getHandle($phid)->getLinkName()); return $this->getHandle($phid)->getLinkName();
} }
} }
@ -199,7 +199,11 @@ abstract class PhabricatorApplicationTransaction
foreach ($phids as $phid) { foreach ($phids as $phid) {
$links[] = $this->renderHandleLink($phid); $links[] = $this->renderHandleLink($phid);
} }
return phutil_implode_html(', ', $links); if ($this->renderingTarget == self::TARGET_HTML) {
return phutil_implode_html(', ', $links);
} else {
return implode(', ', $links);
}
} }
public function renderPolicyName($phid) { public function renderPolicyName($phid) {