From caa5b050b1267e68221adf022a95ff5f882f970f Mon Sep 17 00:00:00 2001
From: Ricky Elrod <ricky@elrod.me>
Date: Thu, 21 Jul 2011 02:17:30 -0400
Subject: [PATCH] Fix header display bug on forked pastes.

Summary:
You can only call setHeader() on a Panel once. Otherwise the last sticks. Move the "forks of this paste" stuff to its own panel (only shown if there are, indeed, forks), and make the columns look nicer.

Test Plan:
Viewed previously forked pastes, forked a paste and looked at the original, and looked at a non-forked paste. All looked sane.

Reviewers:
epriestley

CC:

Differential Revision: 700
---
 .../view/PhabricatorPasteViewController.php   | 33 ++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/src/applications/paste/controller/view/PhabricatorPasteViewController.php b/src/applications/paste/controller/view/PhabricatorPasteViewController.php
index a02e0b30af..86ee7d63d7 100644
--- a/src/applications/paste/controller/view/PhabricatorPasteViewController.php
+++ b/src/applications/paste/controller/view/PhabricatorPasteViewController.php
@@ -42,18 +42,18 @@ class PhabricatorPasteViewController extends PhabricatorPasteController {
     }
 
     $corpus = $this->buildCorpus($paste, $file);
-    $panel = new AphrontPanelView();
+    $paste_panel = new AphrontPanelView();
 
     if (strlen($paste->getTitle())) {
-      $panel->setHeader(
+      $paste_panel->setHeader(
         'Viewing Paste '.$paste->getID().' - '.
         phutil_escape_html($paste->getTitle()));
     } else {
-      $panel->setHeader('Viewing Paste '.$paste->getID());
+      $paste_panel->setHeader('Viewing Paste '.$paste->getID());
     }
 
-    $panel->setWidth(AphrontPanelView::WIDTH_FULL);
-    $panel->addButton(
+    $paste_panel->setWidth(AphrontPanelView::WIDTH_FULL);
+    $paste_panel->addButton(
       phutil_render_tag(
         'a',
         array(
@@ -63,7 +63,7 @@ class PhabricatorPasteViewController extends PhabricatorPasteController {
         'Fork This'));
 
     $raw_uri = PhabricatorFileURI::getViewURIForPHID($paste->getFilePHID());
-    $panel->addButton(
+    $paste_panel->addButton(
       phutil_render_tag(
         'a',
         array(
@@ -72,13 +72,16 @@ class PhabricatorPasteViewController extends PhabricatorPasteController {
         ),
         'View Raw Text'));
 
-    $panel->appendChild($corpus);
+    $paste_panel->appendChild($corpus);
 
+    $forks_panel = null;
     $forks_of_this_paste = id(new PhabricatorPaste())->loadAllWhere(
       'parentPHID = %s',
       $paste->getPHID());
 
     if ($forks_of_this_paste) {
+      $forks_panel = new AphrontPanelView();
+      $forks_panel->setHeader("Forks of this paste");
       $forks = array();
       foreach ($forks_of_this_paste as $fork) {
         $forks[] = array(
@@ -92,7 +95,6 @@ class PhabricatorPasteViewController extends PhabricatorPasteController {
           )
         );
       }
-
       $forks_table = new AphrontTableView($forks);
       $forks_table->setHeaders(
         array(
@@ -100,13 +102,20 @@ class PhabricatorPasteViewController extends PhabricatorPasteController {
           'Title',
         )
       );
-
-      $panel->setHeader("Forks of this Paste");
-      $panel->appendChild($forks_table);
+      $forks_table->setColumnClasses(
+        array(
+          null,
+          'wide pri',
+        )
+      );
+      $forks_panel->appendChild($forks_table);
     }
 
     return $this->buildStandardPageResponse(
-      $panel,
+      array(
+        $paste_panel,
+        $forks_panel,
+      ),
       array(
         'title' => 'Paste: '.nonempty($paste->getTitle(), 'P'.$paste->getID()),
         'tab' => 'view',