1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-09 22:31:03 +01:00

render_tag -> tag: more miscellaenous easy cases

Summary: These all yeilded fairly easily.

Test Plan: Inspection / loaded pages.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4694
This commit is contained in:
epriestley 2013-01-28 18:46:48 -08:00
parent da27b448fa
commit caa7fcef58
4 changed files with 16 additions and 9 deletions

View file

@ -520,7 +520,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
if (strlen($task->getDescription())) { if (strlen($task->getDescription())) {
$view->addSectionHeader(pht('Description')); $view->addSectionHeader(pht('Description'));
$view->addTextContent( $view->addTextContent(
phutil_render_tag( phutil_tag(
'div', 'div',
array( array(
'class' => 'phabricator-remarkup', 'class' => 'phabricator-remarkup',

View file

@ -348,7 +348,7 @@ final class ManiphestTaskListController extends ManiphestController {
$count = number_format(count($list)); $count = number_format(count($list));
$header = $header =
javelin_render_tag( javelin_tag(
'h1', 'h1',
array( array(
'class' => 'maniphest-task-group-header', 'class' => 'maniphest-task-group-header',
@ -357,7 +357,7 @@ final class ManiphestTaskListController extends ManiphestController {
'priority' => head($list)->getPriority(), 'priority' => head($list)->getPriority(),
), ),
), ),
phutil_escape_html($group).' ('.$count.')'); $group.' ('.$count.')');
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();

View file

@ -120,16 +120,23 @@ final class PhabricatorApplicationLaunchView extends AphrontView {
$classes[] = 'application-tile-full'; $classes[] = 'application-tile-full';
} }
$app_button = phutil_render_tag( $app_button = phutil_tag(
$application ? 'a' : 'div', $application ? 'a' : 'div',
array( array(
'class' => implode(' ', $classes), 'class' => implode(' ', $classes),
'href' => $application ? $application->getBaseURI() : null, 'href' => $application ? $application->getBaseURI() : null,
'title' => $application ? $application->getShortDescription() : null, 'title' => $application ? $application->getShortDescription() : null,
), ),
$icon. $this->renderHTMLView(
$this->renderSingleView($content)); array(
$icon,
$content,
)));
return $app_button.$create_button; return $this->renderHTMLView(
array(
$app_button,
$create_button,
));
} }
} }

View file

@ -122,13 +122,13 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
), ),
pht('Preview')); pht('Preview'));
return phutil_render_tag( return phutil_tag(
'div', 'div',
array( array(
'id' => $this->getPreviewPanelID(), 'id' => $this->getPreviewPanelID(),
'style' => 'display: none', 'style' => 'display: none',
), ),
self::renderSingleView( self::renderHTMLView(
array( array(
$header, $header,
$preview, $preview,