From cab2bba6f2f7d712186e8b88265bfc5e523aca13 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sun, 21 Jan 2018 17:17:36 -0800
Subject: [PATCH] Remove "passwordHash" and "passwordSalt" from User objects

Summary:
Ref T13043. After D18903, this data has migrated to shared infrastructure and has no remaining readers or writers.

Just delete it now, since the cost of a mistake here is very small (users need to "Forgot Password?" and pick a new password).

Test Plan: Grepped for `passwordHash`, `passwordSalt`, and variations.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13043

Differential Revision: https://secure.phabricator.com/D18904
---
 resources/sql/autopatches/20180121.auth.05.accountnuke.sql | 5 +++++
 src/applications/people/storage/PhabricatorUser.php        | 4 ----
 2 files changed, 5 insertions(+), 4 deletions(-)
 create mode 100644 resources/sql/autopatches/20180121.auth.05.accountnuke.sql

diff --git a/resources/sql/autopatches/20180121.auth.05.accountnuke.sql b/resources/sql/autopatches/20180121.auth.05.accountnuke.sql
new file mode 100644
index 0000000000..c8dc50bcf2
--- /dev/null
+++ b/resources/sql/autopatches/20180121.auth.05.accountnuke.sql
@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_user.user
+  DROP passwordSalt;
+
+ALTER TABLE {$NAMESPACE}_user.user
+  DROP passwordHash;
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
index 18a3f8a2b7..840bec7d50 100644
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -29,8 +29,6 @@ final class PhabricatorUser
 
   protected $userName;
   protected $realName;
-  protected $passwordSalt;
-  protected $passwordHash;
   protected $profileImagePHID;
   protected $defaultProfileImagePHID;
   protected $defaultProfileImageVersion;
@@ -217,8 +215,6 @@ final class PhabricatorUser
       self::CONFIG_COLUMN_SCHEMA => array(
         'userName' => 'sort64',
         'realName' => 'text128',
-        'passwordSalt' => 'text32?',
-        'passwordHash' => 'text128?',
         'profileImagePHID' => 'phid?',
         'conduitCertificate' => 'text255',
         'isSystemAgent' => 'bool',