revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Give "create" transactions a readable type in "transaction.search"

Browse source 
Summary:
Ref T13151. See PHI725. By default, "transaction.search" doesn't provide details about transactions because many have bad/weird/policy-violating internal types or fields.

The "create" transaction is simple and straightforward, so label it to allow callers to distinguish it.

Test Plan:
  - Created a new task.
  - Called `transaction.search` on it.
  - Saw the labelled "create" transaction.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: swisspol

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19505
This commit is contained in:
epriestley 2018-06-22 10:36:37 -07:00
parent d84f866ca0
commit cac3dc4983
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
View file

@ -205,6 +205,9 @@ final class TransactionSearchConduitAPIMethod
case PhabricatorTransactions::TYPE_COMMENT: case PhabricatorTransactions::TYPE_COMMENT:
$type = 'comment'; $type = 'comment';
break; break;
case PhabricatorTransactions::TYPE_CREATE:
$type = 'create';
break;
} }
} }