revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Dashboard Tabs: render "Move" buttons grayed out more consistently

Browse source 
Summary:
If you happen to create a Dashboard by retrieving other people's panels,
you were probably affected by this visual bug.

It seems that you cannot Move things, but you really can (and that is OK).

The reason is, to move things in a Parent Panel, you only need edit permission there,
and you do not need to also have edit permissions on every Child Panel.

Closes T15492

Test Plan:
- From user A:
    - Create two panels - editable by: User A
- From user B:
    - Create a "Tabs Panel" in a Dashboard
    - Attach the panels from User A (so, editable by, not you)

The meaningful "Move" actions should be not disabled anymore.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15492

Differential Revision: https://we.phorge.it/D25308
This commit is contained in:
Valerio Bozzolan 2023-07-06 13:31:00 +02:00
parent b3ac5ceb38
commit cae1246359
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
View file

@ -181,7 +181,7 @@ final class PhabricatorDashboardTabsPanelType
->setIcon('fa-chevron-left') ->setIcon('fa-chevron-left')
->setHref($prev_uri) ->setHref($prev_uri)
->setWorkflow(true) ->setWorkflow(true)
->setDisabled(($prev_key === null) || !$can_edit)); ->setDisabled($prev_key === null));
$dropdown_menu->addAction( $dropdown_menu->addAction(
id(new PhabricatorActionView()) id(new PhabricatorActionView())
@ -189,7 +189,7 @@ final class PhabricatorDashboardTabsPanelType
->setIcon('fa-chevron-right') ->setIcon('fa-chevron-right')
->setHref($next_uri) ->setHref($next_uri)
->setWorkflow(true) ->setWorkflow(true)
->setDisabled(($next_key === null) || !$can_edit)); ->setDisabled($next_key === null));
$dropdown_menu->addAction( $dropdown_menu->addAction(
id(new PhabricatorActionView()) id(new PhabricatorActionView())