revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Fix exception in Maniphest task ID filtering

Browse source 
Summary:
Ref T2632. When the user enters task IDs, we filter them to allow the user to write `T123` or `task 123` to mean `123`. This filtering is latin-centric and silly, and cuases an exception when accessing, e.g,, `/maniphest/view/custom/?tasks=~`.

Instead of stripping a select few nondigits, strip all nondigits.

Test Plan: Hit `/maniphest/view/custom/?tasks=~`, no exception.

Reviewers: AnhNhan, chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2632

Differential Revision: https://secure.phabricator.com/D5193
This commit is contained in:
epriestley 2013-03-03 10:56:22 -08:00
parent 0dde637059
commit cb2d0adf95
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/controller/ManiphestTaskListController.php
View file

@ -731,7 +731,7 @@ final class ManiphestTaskListController extends ManiphestController {
$numeric_task_ids = array();
foreach ($task_ids as $task_id) {
$task_id = preg_replace('/[a-zA-Z]+/', '', $task_id);
$task_id = preg_replace('/[^\d]+/', '', $task_id);
if (!empty($task_id)) {
$numeric_task_ids[] = $task_id;
}