mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-26 16:52:41 +01:00
Revive essential commit details
Summary: Deleted by D3977. Test Plan: ./reparse.php --message Reviewers: epriestley, edward Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4090
This commit is contained in:
parent
86470e7a30
commit
cb45ad67a3
2 changed files with 33 additions and 19 deletions
|
@ -370,11 +370,8 @@ final class DiffusionCommitController extends DiffusionController {
|
||||||
}
|
}
|
||||||
|
|
||||||
$reviewer_phid = $data->getCommitDetail('reviewerPHID');
|
$reviewer_phid = $data->getCommitDetail('reviewerPHID');
|
||||||
$reviewer_name = $data->getCommitDetail('reviewerName');
|
|
||||||
if ($reviewer_phid) {
|
if ($reviewer_phid) {
|
||||||
$props['Reviewer'] = $handles[$reviewer_phid]->renderLink();
|
$props['Reviewer'] = $handles[$reviewer_phid]->renderLink();
|
||||||
} else if ($reviewer_name) {
|
|
||||||
$props['Reviewer'] = phutil_escape_html($reviewer_name);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
$committer = $data->getCommitDetail('committer');
|
$committer = $data->getCommitDetail('committer');
|
||||||
|
|
|
@ -34,6 +34,34 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
|
||||||
$data->getCommitDetail('authorPHID'));
|
$data->getCommitDetail('authorPHID'));
|
||||||
$data->setCommitDetail('authorPHID', $author_phid);
|
$data->setCommitDetail('authorPHID', $author_phid);
|
||||||
|
|
||||||
|
$user = new PhabricatorUser();
|
||||||
|
if ($author_phid) {
|
||||||
|
$user = $user->loadOneWhere(
|
||||||
|
'phid = %s',
|
||||||
|
$author_phid);
|
||||||
|
}
|
||||||
|
|
||||||
|
$call = new ConduitCall(
|
||||||
|
'differential.parsecommitmessage',
|
||||||
|
array(
|
||||||
|
'corpus' => $message,
|
||||||
|
'partial' => true,
|
||||||
|
));
|
||||||
|
$call->setUser($user);
|
||||||
|
$result = $call->execute();
|
||||||
|
|
||||||
|
$field_values = $result['fields'];
|
||||||
|
|
||||||
|
if (!empty($field_values['reviewedByPHIDs'])) {
|
||||||
|
$data->setCommitDetail(
|
||||||
|
'reviewerPHID',
|
||||||
|
reset($field_values['reviewedByPHIDs']));
|
||||||
|
}
|
||||||
|
|
||||||
|
$data->setCommitDetail(
|
||||||
|
'differential.revisionID',
|
||||||
|
idx($field_values, 'revisionID'));
|
||||||
|
|
||||||
$committer_phid = $this->lookupUser(
|
$committer_phid = $this->lookupUser(
|
||||||
$commit,
|
$commit,
|
||||||
$data->getCommitDetail('committer'),
|
$data->getCommitDetail('committer'),
|
||||||
|
@ -81,6 +109,10 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
|
||||||
|
|
||||||
$revision = id(new DifferentialRevision())->load($revision_id);
|
$revision = id(new DifferentialRevision())->load($revision_id);
|
||||||
if ($revision) {
|
if ($revision) {
|
||||||
|
$data->setCommitDetail(
|
||||||
|
'differential.revisionPHID',
|
||||||
|
$revision->getPHID());
|
||||||
|
|
||||||
$revision->loadRelationships();
|
$revision->loadRelationships();
|
||||||
queryfx(
|
queryfx(
|
||||||
$conn_w,
|
$conn_w,
|
||||||
|
@ -150,22 +182,7 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
|
||||||
$lock->unlock();
|
$lock->unlock();
|
||||||
}
|
}
|
||||||
|
|
||||||
if ($should_autoclose && $author_phid) {
|
if ($should_autoclose) {
|
||||||
$user = id(new PhabricatorUser())->loadOneWhere(
|
|
||||||
'phid = %s',
|
|
||||||
$author_phid);
|
|
||||||
|
|
||||||
$call = new ConduitCall(
|
|
||||||
'differential.parsecommitmessage',
|
|
||||||
array(
|
|
||||||
'corpus' => $message,
|
|
||||||
'partial' => true,
|
|
||||||
));
|
|
||||||
$call->setUser($user);
|
|
||||||
$result = $call->execute();
|
|
||||||
|
|
||||||
$field_values = $result['fields'];
|
|
||||||
|
|
||||||
$fields = DifferentialFieldSelector::newSelector()
|
$fields = DifferentialFieldSelector::newSelector()
|
||||||
->getFieldSpecifications();
|
->getFieldSpecifications();
|
||||||
foreach ($fields as $key => $field) {
|
foreach ($fields as $key => $field) {
|
||||||
|
|
Loading…
Reference in a new issue