From cb5a72b5e6d151d650efdd1a552f5068c83fd1b6 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Fri, 17 May 2024 10:27:55 +0200 Subject: [PATCH] Fix call to non-existing getDisplayName() in DiffusionRepositoryClusterEngine.php Summary: `DiffusionRepositoryClusterEngine` calls `$this->getDisplayName()` which is not defined in this class or its parent class. Looking at the variable use in the companying error message, getting the name of the `$repository` was intended instead. Test Plan: Carefully read the code and check available methods in its parent classes. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25653 --- .../diffusion/protocol/DiffusionRepositoryClusterEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php b/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php index dfc86e5f56..0b2f40c2d6 100644 --- a/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php +++ b/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php @@ -586,7 +586,7 @@ final class DiffusionRepositoryClusterEngine extends Phobject { 'for %s seconds(s). This repository will be frozen.', $this->clusterWriteOwner, $device->getName(), - $this->getDisplayName(), + $repository->getDisplayName(), new PhutilNumber($duration))); }