From cb85be81d8193fbbbb41c4cf7cc89d1c0501c2b0 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 6 Jun 2017 14:04:09 +0000
Subject: [PATCH] Add checkbox images for remarkup

Summary: Minor, adds some weightier checkbox styles for use in Remarkup.

Test Plan:
Test a task, Phriction, various remarkup list styles.

{F4990161}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: cspeckmim, Korvin

Differential Revision: https://secure.phabricator.com/D18080
---
 resources/celerity/map.php                    |   8 +++--
 webroot/rsrc/css/core/remarkup.css            |  29 +++++++++++++++---
 .../rsrc/image/controls/checkbox-checked.png  | Bin 0 -> 514 bytes
 .../image/controls/checkbox-unchecked.png     | Bin 0 -> 328 bytes
 4 files changed, 30 insertions(+), 7 deletions(-)
 create mode 100644 webroot/rsrc/image/controls/checkbox-checked.png
 create mode 100644 webroot/rsrc/image/controls/checkbox-unchecked.png

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 0745c41d4d..6dfa36b3bd 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => 'ff161f2d',
     'conpherence.pkg.js' => 'b5b51108',
-    'core.pkg.css' => '1a935531',
+    'core.pkg.css' => '176b5104',
     'core.pkg.js' => '1475bd91',
     'darkconsole.pkg.js' => '1f9a31bc',
     'differential.pkg.css' => '1ccbf3a9',
@@ -115,7 +115,7 @@ return array(
     'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
     'rsrc/css/application/uiexample/example.css' => '528b19de',
     'rsrc/css/core/core.css' => '23beb330',
-    'rsrc/css/core/remarkup.css' => 'd1a5e11e',
+    'rsrc/css/core/remarkup.css' => '509fb36e',
     'rsrc/css/core/syntax.css' => 'cae95e89',
     'rsrc/css/core/z-index.css' => '9d8f7c4b',
     'rsrc/css/diviner/diviner-shared.css' => '896f1d43',
@@ -298,6 +298,8 @@ return array(
     'rsrc/image/checker_dark.png' => 'd8e65881',
     'rsrc/image/checker_light.png' => 'a0155918',
     'rsrc/image/checker_lighter.png' => 'd5da91b6',
+    'rsrc/image/controls/checkbox-checked.png' => 'ad6441ea',
+    'rsrc/image/controls/checkbox-unchecked.png' => '8eb1f0ae',
     'rsrc/image/d5d8e1.png' => '0c2a1497',
     'rsrc/image/darkload.gif' => '1ffd3ec6',
     'rsrc/image/divot.png' => '94dded62',
@@ -793,7 +795,7 @@ return array(
     'phabricator-object-selector-css' => '85ee8ce6',
     'phabricator-phtize' => 'd254d646',
     'phabricator-prefab' => 'c5af80a2',
-    'phabricator-remarkup-css' => 'd1a5e11e',
+    'phabricator-remarkup-css' => '509fb36e',
     'phabricator-search-results-css' => '8f8e08ed',
     'phabricator-shaped-request' => '7cbe244b',
     'phabricator-slowvote-css' => 'a94b7230',
diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css
index 0c07c145a8..98529b9434 100644
--- a/webroot/rsrc/css/core/remarkup.css
+++ b/webroot/rsrc/css/core/remarkup.css
@@ -122,17 +122,38 @@
 .phabricator-remarkup .remarkup-list-with-checkmarks .remarkup-checked-item,
 .phabricator-remarkup .remarkup-list-with-checkmarks .remarkup-unchecked-item {
   list-style: none;
-  margin-left: -18px;
+  margin-left: -20px;
+  position: relative;
+  padding-left: 22px;
 }
 
 .phabricator-remarkup .remarkup-list-with-checkmarks input {
-  margin-right: 4px;
-  opacity: 1;
+  display: none;
+}
+
+.phabricator-remarkup .remarkup-list-with-checkmarks
+  .remarkup-list-item::before {
+    height: 16px;
+    width: 16px;
+    background-size: 16px;
+    display: inline-block;
+    content: '';
+    position: absolute;
+    top: 3px;
+    left: 0;
+}
+
+.remarkup-list-with-checkmarks .remarkup-checked-item::before {
+  background-image: url(rsrc/image/controls/checkbox-checked.png);
+}
+
+.remarkup-list-with-checkmarks .remarkup-unchecked-item::before {
+  background-image: url(rsrc/image/controls/checkbox-unchecked.png);
 }
 
 .phabricator-remarkup .remarkup-list-with-checkmarks .remarkup-checked-item {
-  text-decoration: line-through;
   color: {$lightgreytext};
+  text-decoration: line-through;
 }
 
 .phabricator-remarkup ul.remarkup-list ol.remarkup-list,
diff --git a/webroot/rsrc/image/controls/checkbox-checked.png b/webroot/rsrc/image/controls/checkbox-checked.png
new file mode 100644
index 0000000000000000000000000000000000000000..9e93e82a373045bb5b4f726f4493006522674eba
GIT binary patch
literal 514
zcmV+d0{#7oP)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80005WNkl<ZScUDE
zPiosh7)RfXvMeE6;dSZOW^Chi2?2p-(;LWRe1<|0bQO9Ck9>n3pyU9-lD!V}05*6N
z5^pWKNTk}tRuumeE&Z)Vj7IOxd?PUu{eB<dBk&!#1kO2b9)VlnEAZ<K_ypVm7e@wX
zIS0M~pMj19ZcYea%>{5Hd0zIaawR!_&5QCuRtN{+zraxiT-U8mKq*BShG?x%FQAmd
z7=z<D_`Y8#ad3fEcoxs|wwB}Uknm=+i7^H#|IBN-TrwC8m`<k~$CO%uGMi}|+*-?I
zGTA!rO#!VnVHl#6+6g`$j|-n)SOTpzzV8EIj6n!Nk|b;Qv|25?-R@5CLIKxx@jNfT
zb{q#|3_vc?Znp`7U=5z8DNz)af&(~8sc)M)7K;V5*^GL<o&$ssG#U-&^EtIzZ6n-T
z`)ZYnQdoj)7QJ3C2T3Ujf*^121AkK>lMq6zZL(GHK5!`c8YW4CwU#tZU-e}*-vwS;
zAd`rqXiXx6$8o$99NzgQjN=#~M7{@x!{J`=cMAZFMx%}GlL;IOoaNs>5&bm+j}`J4
zlII`As`66;*T6#s@CV>p0{1`%_yIhf0Q~gA>Hzn@0i*G+3o|a>YXATM07*qoM6N<$
Eg1uqZivR!s

literal 0
HcmV?d00001

diff --git a/webroot/rsrc/image/controls/checkbox-unchecked.png b/webroot/rsrc/image/controls/checkbox-unchecked.png
new file mode 100644
index 0000000000000000000000000000000000000000..e60350d77099dd164b96d039643a9eb4dcb66f44
GIT binary patch
literal 328
zcmV-O0k{5%P)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80003GNkl<ZScUD=
zF-`(O7>4184UvXq58x3n5h^`{dI7cASh(5{?qX%MS{g5)cd!!;9D$lFfdVTFmt?b{
zAd$spzGRwj{>=MMGSf)YRFMPR;}S<`+ieyY;{}iShGwyOh*xxX3@xXP(_-D=0@KLv
z&Fh9&)5RNF5$^U3U*{ONO<a}RPNySD5^)^wl$PhYEXzzLlX86>p;vC|fI}R|k|e3t
zy$G%9U|rd8b}Oolwq=4q5C{T6AP5A3AP@wCK!jDf$n(55*nB>(R*MK9<z_e>ZW{b^
zX0w?r%c}Lbk)~-M4?8DrmwtpNeEtLc3(xB}aE{R);Uk=3wf+TDoM3==ENg%+i?as>
aYYIQml{{z<<^5>@0000<MNUMnLSTaMRfoy|

literal 0
HcmV?d00001