From cba5a866f83a8db159d08e490d9c9f7bc00b5422 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Wed, 16 Jan 2013 07:49:05 -0800
Subject: [PATCH] Consistent panels for account settings.

Summary: Sets all panels to full width and no backgrounds in settings for consistency.

Test Plan: Check each page width.

Reviewers: epriestley, codeblock, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4460
---
 .../settings/panel/PhabricatorSettingsPanelAccount.php        | 2 +-
 .../settings/panel/PhabricatorSettingsPanelConduit.php        | 4 ++--
 .../panel/PhabricatorSettingsPanelDisplayPreferences.php      | 2 +-
 .../settings/panel/PhabricatorSettingsPanelEmailAddresses.php | 1 +
 .../panel/PhabricatorSettingsPanelEmailPreferences.php        | 2 +-
 .../settings/panel/PhabricatorSettingsPanelLDAP.php           | 3 ++-
 .../settings/panel/PhabricatorSettingsPanelOAuth.php          | 3 ++-
 .../settings/panel/PhabricatorSettingsPanelPassword.php       | 2 +-
 .../settings/panel/PhabricatorSettingsPanelProfile.php        | 2 +-
 .../settings/panel/PhabricatorSettingsPanelSSHKeys.php        | 3 ++-
 .../panel/PhabricatorSettingsPanelSearchPreferences.php       | 2 +-
 11 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelAccount.php b/src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
index c784fb12a7..1e2d588016 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
@@ -90,8 +90,8 @@ final class PhabricatorSettingsPanelAccount
 
     $panel = new AphrontPanelView();
     $panel->setHeader('Account Settings');
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     return array(
       $notice,
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelConduit.php b/src/applications/settings/panel/PhabricatorSettingsPanelConduit.php
index 378e273e22..bdcfd8cada 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelConduit.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelConduit.php
@@ -78,7 +78,7 @@ final class PhabricatorSettingsPanelConduit
     $cert = new AphrontPanelView();
     $cert->setHeader('Arcanist Certificate');
     $cert->appendChild($cert_form);
-    $cert->setWidth(AphrontPanelView::WIDTH_FORM);
+    $cert->setNoBackground();
 
     $regen_form = new AphrontFormView();
     $regen_form
@@ -96,7 +96,7 @@ final class PhabricatorSettingsPanelConduit
     $regen = new AphrontPanelView();
     $regen->setHeader('Regenerate Certificate');
     $regen->appendChild($regen_form);
-    $regen->setWidth(AphrontPanelView::WIDTH_FORM);
+    $regen->setNoBackground();
 
     return array(
       $notice,
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
index b4fbdc457f..c52244cafb 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
@@ -145,9 +145,9 @@ EXAMPLE;
           ->setValue('Save Preferences'));
 
     $panel = new AphrontPanelView();
-    $panel->setWidth(AphrontPanelView::WIDTH_WIDE);
     $panel->setHeader('Display Preferences');
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getStr('saved') === 'true') {
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php b/src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
index b60a74b64d..072c1dcb9e 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
@@ -144,6 +144,7 @@ final class PhabricatorSettingsPanelEmailAddresses
     }
     $view->setHeader('Email Addresses');
     $view->appendChild($table);
+    $view->setNoBackground();
 
     return $view;
   }
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php
index 7209f263bd..dadca328a6 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php
@@ -201,8 +201,8 @@ final class PhabricatorSettingsPanelEmailPreferences
 
     $panel = new AphrontPanelView();
     $panel->setHeader('Email Preferences');
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     return id(new AphrontNullView())
       ->appendChild(
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelLDAP.php b/src/applications/settings/panel/PhabricatorSettingsPanelLDAP.php
index 047a3387c9..ebff08540a 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelLDAP.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelLDAP.php
@@ -70,7 +70,8 @@ final class PhabricatorSettingsPanelLDAP
 
     $panel = new AphrontPanelView();
     $panel->setHeader('LDAP Account Settings');
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+    $panel->setNoBackground();
+
     foreach ($forms as $name => $form) {
       if ($name) {
         $panel->appendChild('<br /><h1>'.$name.'</h1><br />');
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelOAuth.php b/src/applications/settings/panel/PhabricatorSettingsPanelOAuth.php
index 8027e42dcc..41565afbdb 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelOAuth.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelOAuth.php
@@ -204,7 +204,8 @@ final class PhabricatorSettingsPanelOAuth
 
     $panel = new AphrontPanelView();
     $panel->setHeader($provider_name.' Account Settings');
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+    $panel->setNoBackground();
+
     foreach ($forms as $name => $form) {
       if ($name) {
         $panel->appendChild('<br /><h1>'.$name.'</h1><br />');
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelPassword.php b/src/applications/settings/panel/PhabricatorSettingsPanelPassword.php
index a26ff94b79..e7d6e69879 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelPassword.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelPassword.php
@@ -160,8 +160,8 @@ final class PhabricatorSettingsPanelPassword
 
     $panel = new AphrontPanelView();
     $panel->setHeader('Change Password');
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     return array(
       $notice,
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelProfile.php b/src/applications/settings/panel/PhabricatorSettingsPanelProfile.php
index e2e59284e4..3eb398aa4b 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelProfile.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelProfile.php
@@ -198,7 +198,7 @@ final class PhabricatorSettingsPanelProfile
     $panel = new AphrontPanelView();
     $panel->setHeader('Edit Profile Details');
     $panel->appendChild($form);
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+    $panel->setNoBackground();
 
     return array(
       $error_view,
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php b/src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php
index 0a4929af71..7bf018a2b5 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php
@@ -154,8 +154,8 @@ final class PhabricatorSettingsPanelSSHKeys
 
     $panel = new AphrontPanelView();
     $panel->setHeader($header);
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     return id(new AphrontNullView())
       ->appendChild(
@@ -229,6 +229,7 @@ final class PhabricatorSettingsPanelSSHKeys
         'Add New Public Key'));
     $panel->setHeader('SSH Public Keys');
     $panel->appendChild($table);
+    $panel->setNoBackground();
 
     return $panel;
   }
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php
index 9cffc41b6a..57df2da13e 100644
--- a/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php
@@ -52,9 +52,9 @@ final class PhabricatorSettingsPanelSearchPreferences
           ->setValue('Save'));
 
     $panel = new AphrontPanelView();
-    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
     $panel->setHeader('Search Preferences');
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getStr('saved') === 'true') {