revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

When queueing search index tasks, include the "objectPHID" in the task metadata

Browse source 
Summary:
Ref T13151. See PHI719. One minor hiccup in debugging the issue (which ended up being "revision has 100K comments") was that the `SearchWorker` did not show which object it was indexing.

Add `'objectPHID'` to the queue call so you can see which object is affected from the web UI.

Test Plan:
  - Stopped daemons.
  - Used `bin/search index D123 --background` to queue a search task.
  - Viewed task details in web UI from `/daemon/`.
    - Before change: no indication of which object was being indexed.
    - After change: page helpfully shows that the task is indexing D123.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19502
This commit is contained in:
epriestley 2018-06-22 05:36:21 -07:00
parent b1f4a974fe
commit cbc71e75fa
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/search/worker/PhabricatorSearchWorker.php
View file

@ -15,6 +15,7 @@ final class PhabricatorSearchWorker extends PhabricatorWorker {
), ),
array( array(
'priority' => parent::PRIORITY_IMPORT, 'priority' => parent::PRIORITY_IMPORT,
'objectPHID' => $phid,
)); ));
} }