From cc0f0b38652509395d3f8b33b2b4e62234f58b7d Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 18 Oct 2016 14:33:23 -0700 Subject: [PATCH] Don't publish feed stories or send mail about imported events Summary: Ref T10747. Although I could possibly imagine some very selective cases where we do this eventually, these are read-only for now and not interesting to publish/mail about. The presumption is that the original/authoritative system has already notified relevant parties or they're subscribing passively. Test Plan: Imported some name changes for events, saw no more mail/feed stuff. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10747 Differential Revision: https://secure.phabricator.com/D16723 --- .../calendar/editor/PhabricatorCalendarEventEditor.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php index 33442b6702..655037c140 100644 --- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php +++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php @@ -200,6 +200,11 @@ final class PhabricatorCalendarEventEditor protected function shouldPublishFeedStory( PhabricatorLiskDAO $object, array $xactions) { + + if ($object->isImportedEvent()) { + return false; + } + return true; } @@ -210,6 +215,11 @@ final class PhabricatorCalendarEventEditor protected function shouldSendMail( PhabricatorLiskDAO $object, array $xactions) { + + if ($object->isImportedEvent()) { + return false; + } + return true; }