From cc1def6ceaab41483103919e94bd227da01f5cdc Mon Sep 17 00:00:00 2001 From: Austin McKinley Date: Mon, 13 Aug 2018 15:37:04 -0700 Subject: [PATCH] Remove some array typehints for passing around Summary: See discussion at https://secure.phabricator.com/D19492#241996 Test Plan: Refreshed a few Diffusion tabs; nothing broke. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D19578 --- .../repository/storage/PhabricatorRepositoryCommit.php | 6 +++--- .../subscriptions/view/SubscriptionListDialogBuilder.php | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index 8ad182ee7b..bf3b796a76 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -446,7 +446,7 @@ final class PhabricatorRepositoryCommit * the migration to using identities, update this method to remove the * fallback. See T12164 for details. */ - public function renderAnyCommitter(PhabricatorUser $viewer, array $handles) { + public function renderAnyCommitter(PhabricatorUser $viewer, $handles) { $committer = $this->renderCommitter($viewer, $handles); if ($committer) { return $committer; @@ -455,7 +455,7 @@ final class PhabricatorRepositoryCommit return $this->renderAuthor($viewer, $handles); } - public function renderCommitter(PhabricatorUser $viewer, array $handles) { + public function renderCommitter(PhabricatorUser $viewer, $handles) { $committer_phid = $this->getCommitterDisplayPHID(); if ($committer_phid) { return $handles[$committer_phid]->renderLink(); @@ -470,7 +470,7 @@ final class PhabricatorRepositoryCommit return null; } - public function renderAuthor(PhabricatorUser $viewer, array $handles) { + public function renderAuthor(PhabricatorUser $viewer, $handles) { $author_phid = $this->getAuthorDisplayPHID(); if ($author_phid) { return $handles[$author_phid]->renderLink(); diff --git a/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php b/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php index 7d1b8d799c..da157848ea 100644 --- a/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php +++ b/src/applications/subscriptions/view/SubscriptionListDialogBuilder.php @@ -58,7 +58,7 @@ final class SubscriptionListDialogBuilder extends Phobject { ->addCancelButton($object_handle->getURI(), pht('Close')); } - private function buildBody(PhabricatorUser $viewer, array $handles) { + private function buildBody(PhabricatorUser $viewer, $handles) { $list = id(new PHUIObjectItemListView()) ->setUser($viewer);