From cc5ba7e8017ea028af1d15d708916ab90b7db041 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 13 Jun 2014 13:06:04 -0700 Subject: [PATCH] Fix Project Hovercards Summary: Clear the float, remove the abs. position. Test Plan: Test a project hovercard, see expected layout. {F166175} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9519 --- resources/celerity/map.php | 4 ++-- src/view/widget/hovercard/PhabricatorHovercardView.php | 2 +- webroot/rsrc/css/layout/phabricator-hovercard-view.css | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index bc5be6754f..3753b039eb 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -115,7 +115,7 @@ return array( 'rsrc/css/layout/phabricator-action-list-view.css' => '35dbd16e', 'rsrc/css/layout/phabricator-crumbs-view.css' => '7fbf25b8', 'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82', - 'rsrc/css/layout/phabricator-hovercard-view.css' => 'e010d7db', + 'rsrc/css/layout/phabricator-hovercard-view.css' => 'cae6e28f', 'rsrc/css/layout/phabricator-side-menu-view.css' => 'a2ccd7bd', 'rsrc/css/layout/phabricator-source-code-view.css' => '7d346aa4', 'rsrc/css/phui/calendar/phui-calendar-day.css' => 'de035c8a', @@ -703,7 +703,7 @@ return array( 'phabricator-filetree-view-css' => 'fccf9f82', 'phabricator-flag-css' => '5337623f', 'phabricator-hovercard' => '4f344388', - 'phabricator-hovercard-view-css' => 'e010d7db', + 'phabricator-hovercard-view-css' => 'cae6e28f', 'phabricator-keyboard-shortcut' => '1ae869f2', 'phabricator-keyboard-shortcut-manager' => 'ad7a69ca', 'phabricator-main-menu-view' => '72d1d2ef', diff --git a/src/view/widget/hovercard/PhabricatorHovercardView.php b/src/view/widget/hovercard/PhabricatorHovercardView.php index 8a417452f2..21222721ce 100644 --- a/src/view/widget/hovercard/PhabricatorHovercardView.php +++ b/src/view/widget/hovercard/PhabricatorHovercardView.php @@ -158,7 +158,7 @@ final class PhabricatorHovercardView extends AphrontView { 'phabricator-hovercard-container', array( phutil_tag_div('phabricator-hovercard-head', $header), - phutil_tag_div('phabricator-hovercard-body', $body), + phutil_tag_div('phabricator-hovercard-body grouped', $body), $tail, )); diff --git a/webroot/rsrc/css/layout/phabricator-hovercard-view.css b/webroot/rsrc/css/layout/phabricator-hovercard-view.css index 8063e9ab51..8dc40b6838 100644 --- a/webroot/rsrc/css/layout/phabricator-hovercard-view.css +++ b/webroot/rsrc/css/layout/phabricator-hovercard-view.css @@ -65,7 +65,6 @@ .phabricator-hovercard-body .phabricator-hovercard-body-image { width: 58px; - position: absolute; } .phabricator-hovercard-body .phabricator-hovercard-body-details {