revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Link from Blame Revision

Browse source 
Summary: There can be Dxxx, rXXXxxx or even full URL in //Blame Revision// field
so just highlighting it as normal text would work probably best

Test Plan:
Go to https://secure.phabricator.com/D277
You should see a link from //Blame Revision// (if it would be displayed)

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1274
This commit is contained in:
vrana 2011-12-22 15:46:50 -08:00
parent a83a54004d
commit cce212dac7
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/differential/field/specification/blamerev/DifferentialBlameRevisionFieldSpecification.php
View file

@ -67,7 +67,8 @@ final class DifferentialBlameRevisionFieldSpecification
if (!$this->value) { if (!$this->value) {
return null; return null;
} }
return phutil_escape_html($this->value); $engine = PhabricatorMarkupEngine::newDifferentialMarkupEngine();
return $engine->markupText($this->value);
} }
public function shouldAppearOnConduitView() { public function shouldAppearOnConduitView() {

2
src/applications/differential/field/specification/blamerev/__init__.php
View file

@ -7,9 +7,9 @@
phutil_require_module('phabricator', 'applications/differential/field/specification/base'); phutil_require_module('phabricator', 'applications/differential/field/specification/base');
phutil_require_module('phabricator', 'applications/markup/engine');
phutil_require_module('phabricator', 'view/form/control/text'); phutil_require_module('phabricator', 'view/form/control/text');
phutil_require_module('phutil', 'markup');
phutil_require_module('phutil', 'utils'); phutil_require_module('phutil', 'utils');