From cd22d837cbc0798bbe3fb63b25bff6868b8eb34e Mon Sep 17 00:00:00 2001 From: vrana <jakubv@fb.com> Date: Thu, 9 Feb 2012 11:42:28 -0800 Subject: [PATCH] Revive added reviewers and ccs Test Plan: Display revision with added reviewers. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1598 --- .../DifferentialRevisionCommentView.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php index 1a32f2585d..47cc08e279 100644 --- a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php +++ b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php @@ -135,7 +135,9 @@ final class DifferentialRevisionCommentView extends AphrontView { $content = $comment->getContent(); $head_content = null; + $hide_comments = true; if (strlen(rtrim($content))) { + $hide_comments = false; $cache = $comment->getCache(); if (strlen($cache)) { $content = $cache; @@ -156,13 +158,9 @@ final class DifferentialRevisionCommentView extends AphrontView { } $title = "{$author_link} {$verb} this revision."; - if (strlen(rtrim($content)) || $this->inlines) { - $hide_comments_class = null; - } else { - $hide_comments_class = 'hide'; - } if ($this->inlines) { + $hide_comments = false; $inline_render = array(); $inlines = $this->inlines; $changesets = $this->changesets; @@ -310,6 +308,7 @@ final class DifferentialRevisionCommentView extends AphrontView { } if ($metadata_blocks) { + $hide_comments = false; $metadata_blocks = '<div class="differential-comment-metadata">'. implode("\n", $metadata_blocks). @@ -318,6 +317,7 @@ final class DifferentialRevisionCommentView extends AphrontView { $metadata_blocks = null; } + $hide_comments_class = ($hide_comments ? 'hide' : ''); return phutil_render_tag( 'div', array(