From cd46fd4afe671759b8afef84b19fbfeb09487796 Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 17 Dec 2012 14:37:39 -0800 Subject: [PATCH] Mark finished postponed linters as okay Test Plan: Called it on a diff with postponed linters and no messages. Reviewers: mgummelt, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4223 --- .../ConduitAPI_differential_setdiffproperty_Method.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/applications/conduit/method/differential/ConduitAPI_differential_setdiffproperty_Method.php b/src/applications/conduit/method/differential/ConduitAPI_differential_setdiffproperty_Method.php index 8613195f7d..3dc468ca53 100644 --- a/src/applications/conduit/method/differential/ConduitAPI_differential_setdiffproperty_Method.php +++ b/src/applications/conduit/method/differential/ConduitAPI_differential_setdiffproperty_Method.php @@ -77,8 +77,7 @@ final class ConduitAPI_differential_setdiffproperty_Method $diff->setLintStatus(DifferentialLintStatus::LINT_WARN); } else if (!empty($postponed_linters)) { $diff->setLintStatus(DifferentialLintStatus::LINT_POSTPONED); - } else if ($results && - $diff->getLintStatus() === DifferentialLintStatus::LINT_NONE) { + } else if ($diff->getLintStatus() != DifferentialLintStatus::LINT_SKIP) { $diff->setLintStatus(DifferentialLintStatus::LINT_OKAY); } $diff->save();