From cd4e3c6399a5467d0ad6f6562066174dee5c5f7d Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 24 Sep 2014 13:49:25 -0700
Subject: [PATCH] Make Releeph a normal prototype application

Summary: Fixes T6177. Now that we've reframed "Beta" into "Prototype", there's no reason this needs to be in a separate super-hidden class of application anymore.

Test Plan: Saw Releeph available as a normal Prototype application.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T6177

Differential Revision: https://secure.phabricator.com/D10550
---
 .../application/PhabricatorReleephApplication.php   |  7 ++-----
 .../PhabricatorReleephApplicationConfigOptions.php  | 13 -------------
 src/infrastructure/testing/PhabricatorTestCase.php  |  3 ---
 3 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/src/applications/releeph/application/PhabricatorReleephApplication.php b/src/applications/releeph/application/PhabricatorReleephApplication.php
index 91e8246f85..e04337f912 100644
--- a/src/applications/releeph/application/PhabricatorReleephApplication.php
+++ b/src/applications/releeph/application/PhabricatorReleephApplication.php
@@ -18,11 +18,8 @@ final class PhabricatorReleephApplication extends PhabricatorApplication {
     return 'releeph';
   }
 
-  public function isInstalled() {
-    if (PhabricatorEnv::getEnvConfig('releeph.installed')) {
-      return parent::isInstalled();
-    }
-    return false;
+  public function isPrototype() {
+    return true;
   }
 
   public function getRoutes() {
diff --git a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
index 6f54a7ceb2..dc62b59166 100644
--- a/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
+++ b/src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php
@@ -42,19 +42,6 @@ final class PhabricatorReleephApplicationConfigOptions
     $custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType';
 
     return array(
-      $this->newOption('releeph.installed', 'bool', false)
-        ->setSummary(pht('Enable the Releeph application.'))
-        ->setDescription(
-          pht(
-            'Releeph, a tool for managing release branches, will eventually '.
-            'fit in to the Phabricator suite as a general purpose tool. '.
-            'However Releeph is currently unstable in multiple ways that may '.
-            'not migrate properly for you: the code is still in alpha stage '.
-            'of design, the storage format is likely to change in unexpected '.
-            'ways, and the workflows presented are very specific to a core '.
-            'set of alpha testers at Facebook.  For the time being you are '.
-            'strongly discouraged from relying on Releeph being at all '.
-            'stable.')),
       $this->newOption('releeph.fields', $custom_field_type, $default)
         ->setCustomData('ReleephFieldSpecification'),
       $this->newOption(
diff --git a/src/infrastructure/testing/PhabricatorTestCase.php b/src/infrastructure/testing/PhabricatorTestCase.php
index 14e2a30142..effec47d86 100644
--- a/src/infrastructure/testing/PhabricatorTestCase.php
+++ b/src/infrastructure/testing/PhabricatorTestCase.php
@@ -116,9 +116,6 @@ abstract class PhabricatorTestCase extends ArcanistPhutilTestCase {
       'notification.enabled',
       false);
 
-    // TODO: Remove this when we remove "releeph.installed".
-    $this->env->overrideEnvConfig('releeph.installed', true);
-
     $this->env->overrideEnvConfig(
       'phabricator.base-uri',
       'http://phabricator.example.com');