revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

fix Maniphest search for null-like values edge case

Browse source 
Summary: wishlist has priority value of 0 which was messing things up. also fix search text so we can search for "0".

Test Plan: searched for stuff, got results

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1878

Differential Revision: https://secure.phabricator.com/D3948
This commit is contained in:
Bob Trahan 2012-11-12 13:53:33 -08:00
parent f8737d15ca
commit cd8a9c603e
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/maniphest/controller/ManiphestTaskListController.php
View file

@ -31,13 +31,10 @@ final class ManiphestTaskListController extends ManiphestController {
$task_ids = nonempty($task_ids, null); $task_ids = nonempty($task_ids, null);
$search_text = $request->getStr('set_search'); $search_text = $request->getStr('set_search');
$search_text = nonempty($search_text, null);
$min_priority = $request->getInt('set_lpriority'); $min_priority = $request->getInt('set_lpriority');
$min_priority = nonempty($min_priority, null);
$max_priority = $request->getInt('set_hpriority'); $max_priority = $request->getInt('set_hpriority');
$max_priority = nonempty($max_priority, null);
$uri = $request->getRequestURI() $uri = $request->getRequestURI()
->alter('users', $this->getArrToStrList('set_users')) ->alter('users', $this->getArrToStrList('set_users'))
@ -230,7 +227,7 @@ final class ManiphestTaskListController extends ManiphestController {
->setValue($tokens)); ->setValue($tokens));
$priority = ManiphestTaskPriority::getLowestPriority(); $priority = ManiphestTaskPriority::getLowestPriority();
if ($low_priority) { if ($low_priority !== null) {
$priority = $low_priority; $priority = $low_priority;
} }
@ -243,7 +240,7 @@ final class ManiphestTaskListController extends ManiphestController {
ManiphestTaskPriority::getTaskPriorityMap(), true))); ManiphestTaskPriority::getTaskPriorityMap(), true)));
$priority = ManiphestTaskPriority::getHighestPriority(); $priority = ManiphestTaskPriority::getHighestPriority();
if ($high_priority) { if ($high_priority !== null) {
$priority = $high_priority; $priority = $high_priority;
} }
@ -426,10 +423,10 @@ final class ManiphestTaskListController extends ManiphestController {
$author_phids = $search_query->getParameter('authorPHIDs', array()); $author_phids = $search_query->getParameter('authorPHIDs', array());
$low_priority = $search_query->getParameter('lowPriority'); $low_priority = $search_query->getParameter('lowPriority');
$low_priority = nonempty($low_priority, $low_priority = coalesce($low_priority,
ManiphestTaskPriority::getLowestPriority()); ManiphestTaskPriority::getLowestPriority());
$high_priority = $search_query->getParameter('highPriority'); $high_priority = $search_query->getParameter('highPriority');
$high_priority = nonempty($high_priority, $high_priority = coalesce($high_priority,
ManiphestTaskPriority::getHighestPriority()); ManiphestTaskPriority::getHighestPriority());
$query = new ManiphestTaskQuery(); $query = new ManiphestTaskQuery();