revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Revising Flag UI

Browse source 
Summary:
Re-adding side nav (feels less spacy now).

Replaced header with crumb. Looks nicer with the filter imo.

Test Plan: {F38201}

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5517
This commit is contained in:
Anh Nhan Nguyen 2013-04-01 06:28:38 -07:00 committed by epriestley
parent 6e197fe91c
commit cdcd49e4ee
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/applications/flag/controller/PhabricatorFlagListController.php
View file

@ -7,6 +7,16 @@ final class PhabricatorFlagListController extends PhabricatorFlagController {
$user = $request->getUser(); $user = $request->getUser();
$nav = new AphrontSideNavFilterView(); $nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI('/flag/view/'));
$nav->addLabel(pht('Flags'));
$nav->addFilter('all', pht('Your Flags'));
$nav->selectFilter('all', 'all');
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(id(new PhabricatorCrumbView)
->setName(pht('Flags'))
->setHref($request->getRequestURI()));
$nav->setCrumbs($crumbs);
$filter_form = new AphrontFormView(); $filter_form = new AphrontFormView();
$filter_form->setUser($user); $filter_form->setUser($user);
@ -26,6 +36,7 @@ final class PhabricatorFlagListController extends PhabricatorFlagController {
$filter = new AphrontListFilterView(); $filter = new AphrontListFilterView();
$filter->appendChild($filter_form); $filter->appendChild($filter_form);
$nav->appendChild($filter);
$query = new PhabricatorFlagQuery(); $query = new PhabricatorFlagQuery();
$query->withOwnerPHIDs(array($user->getPHID())); $query->withOwnerPHIDs(array($user->getPHID()));
@ -56,11 +67,6 @@ final class PhabricatorFlagListController extends PhabricatorFlagController {
$view->setFlags($flags); $view->setFlags($flags);
$view->setUser($user); $view->setUser($user);
$header = new PhabricatorHeaderView();
$header->setHeader(pht('Flags'));
$nav->appendChild($header);
$nav->appendChild($filter);
$nav->appendChild($view); $nav->appendChild($view);
return $this->buildApplicationPage( return $this->buildApplicationPage(