revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

CSS Tweaks to reviewers status list

Browse source 
Summary: Updates the review status list to align better inside property lists. Alsu uses the default colors a bit more. This removes an overflow hidden on the value side, but that shouldnt cause any issues, given it has plenty of space.

Test Plan: tested differential and audit, highlighted and not.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7441
This commit is contained in:
Chad Little 2013-10-29 20:26:41 -07:00
parent 62edbb8e21
commit cdcfbb69a0
4 changed files with 54 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
src/__celerity_resource_map__.php
View file

@ -3930,7 +3930,7 @@ celerity_register_resource_map(array(
),
'phui-property-list-view-css' =>
array(
'uri' => '/res/dc22cea9/rsrc/css/phui/phui-property-list-view.css',
'uri' => '/res/b307acfe/rsrc/css/phui/phui-property-list-view.css',
'type' => 'css',
'requires' =>
array(
@ -3957,7 +3957,7 @@ celerity_register_resource_map(array(
),
'phui-status-list-view-css' =>
array(
'uri' => '/res/3410386e/rsrc/css/phui/phui-status.css',
'uri' => '/res/868f8a95/rsrc/css/phui/phui-status.css',
'type' => 'css',
'requires' =>
array(
@ -4318,7 +4318,7 @@ celerity_register_resource_map(array(
), array(
'packages' =>
array(
'a8252666' =>
'e3e5a752' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@ -4367,7 +4367,7 @@ celerity_register_resource_map(array(
41 => 'phabricator-tag-view-css',
42 => 'phui-list-view-css',
),
'uri' => '/res/pkg/a8252666/core.pkg.css',
'uri' => '/res/pkg/e3e5a752/core.pkg.css',
'type' => 'css',
),
'2c1dba03' =>
@ -4559,15 +4559,15 @@ celerity_register_resource_map(array(
),
'reverse' =>
array(
'aphront-dialog-view-css' => 'a8252666',
'aphront-error-view-css' => 'a8252666',
'aphront-list-filter-view-css' => 'a8252666',
'aphront-pager-view-css' => 'a8252666',
'aphront-panel-view-css' => 'a8252666',
'aphront-table-view-css' => 'a8252666',
'aphront-tokenizer-control-css' => 'a8252666',
'aphront-tooltip-css' => 'a8252666',
'aphront-typeahead-control-css' => 'a8252666',
'aphront-dialog-view-css' => 'e3e5a752',
'aphront-error-view-css' => 'e3e5a752',
'aphront-list-filter-view-css' => 'e3e5a752',
'aphront-pager-view-css' => 'e3e5a752',
'aphront-panel-view-css' => 'e3e5a752',
'aphront-table-view-css' => 'e3e5a752',
'aphront-tokenizer-control-css' => 'e3e5a752',
'aphront-tooltip-css' => 'e3e5a752',
'aphront-typeahead-control-css' => 'e3e5a752',
'differential-changeset-view-css' => '1084b12b',
'differential-core-view-css' => '1084b12b',
'differential-inline-comment-editor' => '5e9e5c4e',
@ -4581,7 +4581,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '1084b12b',
'diffusion-commit-view-css' => '270f4eb4',
'diffusion-icons-css' => '270f4eb4',
'global-drag-and-drop-css' => 'a8252666',
'global-drag-and-drop-css' => 'e3e5a752',
'inline-comment-summary-css' => '1084b12b',
'javelin-aphlict' => '2c1dba03',
'javelin-behavior' => '3e3be199',
@ -4656,56 +4656,56 @@ celerity_register_resource_map(array(
'javelin-util' => '3e3be199',
'javelin-vector' => '3e3be199',
'javelin-workflow' => '3e3be199',
'lightbox-attachment-css' => 'a8252666',
'lightbox-attachment-css' => 'e3e5a752',
'maniphest-task-summary-css' => '49898640',
'phabricator-action-list-view-css' => 'a8252666',
'phabricator-application-launch-view-css' => 'a8252666',
'phabricator-action-list-view-css' => 'e3e5a752',
'phabricator-application-launch-view-css' => 'e3e5a752',
'phabricator-busy' => '2c1dba03',
'phabricator-content-source-view-css' => '1084b12b',
'phabricator-core-css' => 'a8252666',
'phabricator-crumbs-view-css' => 'a8252666',
'phabricator-core-css' => 'e3e5a752',
'phabricator-crumbs-view-css' => 'e3e5a752',
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
'phabricator-dropdown-menu' => '2c1dba03',
'phabricator-file-upload' => '2c1dba03',
'phabricator-filetree-view-css' => 'a8252666',
'phabricator-flag-css' => 'a8252666',
'phabricator-filetree-view-css' => 'e3e5a752',
'phabricator-flag-css' => 'e3e5a752',
'phabricator-hovercard' => '2c1dba03',
'phabricator-jump-nav' => 'a8252666',
'phabricator-jump-nav' => 'e3e5a752',
'phabricator-keyboard-shortcut' => '2c1dba03',
'phabricator-keyboard-shortcut-manager' => '2c1dba03',
'phabricator-main-menu-view' => 'a8252666',
'phabricator-main-menu-view' => 'e3e5a752',
'phabricator-menu-item' => '2c1dba03',
'phabricator-nav-view-css' => 'a8252666',
'phabricator-nav-view-css' => 'e3e5a752',
'phabricator-notification' => '2c1dba03',
'phabricator-notification-css' => 'a8252666',
'phabricator-notification-menu-css' => 'a8252666',
'phabricator-notification-css' => 'e3e5a752',
'phabricator-notification-menu-css' => 'e3e5a752',
'phabricator-object-selector-css' => '1084b12b',
'phabricator-phtize' => '2c1dba03',
'phabricator-prefab' => '2c1dba03',
'phabricator-project-tag-css' => '49898640',
'phabricator-remarkup-css' => 'a8252666',
'phabricator-remarkup-css' => 'e3e5a752',
'phabricator-shaped-request' => '5e9e5c4e',
'phabricator-side-menu-view-css' => 'a8252666',
'phabricator-standard-page-view' => 'a8252666',
'phabricator-tag-view-css' => 'a8252666',
'phabricator-side-menu-view-css' => 'e3e5a752',
'phabricator-standard-page-view' => 'e3e5a752',
'phabricator-tag-view-css' => 'e3e5a752',
'phabricator-textareautils' => '2c1dba03',
'phabricator-tooltip' => '2c1dba03',
'phabricator-transaction-view-css' => 'a8252666',
'phabricator-zindex-css' => 'a8252666',
'phui-button-css' => 'a8252666',
'phui-form-css' => 'a8252666',
'phui-form-view-css' => 'a8252666',
'phui-header-view-css' => 'a8252666',
'phui-icon-view-css' => 'a8252666',
'phui-list-view-css' => 'a8252666',
'phui-object-item-list-view-css' => 'a8252666',
'phui-property-list-view-css' => 'a8252666',
'phui-spacing-css' => 'a8252666',
'sprite-apps-large-css' => 'a8252666',
'sprite-gradient-css' => 'a8252666',
'sprite-icons-css' => 'a8252666',
'sprite-menu-css' => 'a8252666',
'sprite-status-css' => 'a8252666',
'syntax-highlighting-css' => 'a8252666',
'phabricator-transaction-view-css' => 'e3e5a752',
'phabricator-zindex-css' => 'e3e5a752',
'phui-button-css' => 'e3e5a752',
'phui-form-css' => 'e3e5a752',
'phui-form-view-css' => 'e3e5a752',
'phui-header-view-css' => 'e3e5a752',
'phui-icon-view-css' => 'e3e5a752',
'phui-list-view-css' => 'e3e5a752',
'phui-object-item-list-view-css' => 'e3e5a752',
'phui-property-list-view-css' => 'e3e5a752',
'phui-spacing-css' => 'e3e5a752',
'sprite-apps-large-css' => 'e3e5a752',
'sprite-gradient-css' => 'e3e5a752',
'sprite-icons-css' => 'e3e5a752',
'sprite-menu-css' => 'e3e5a752',
'sprite-status-css' => 'e3e5a752',
'syntax-highlighting-css' => 'e3e5a752',
),
));

6
src/applications/differential/view/DifferentialReviewersView.php
View file

@ -43,7 +43,7 @@ final class DifferentialReviewersView extends AphrontView {
switch ($reviewer->getStatus()) {
case DifferentialReviewerStatus::STATUS_ADDED:
$item->setIcon('open-dark', pht('Review Requested'));
$item->setIcon('open', pht('Review Requested'));
break;
case DifferentialReviewerStatus::STATUS_ACCEPTED:
@ -73,7 +73,7 @@ final class DifferentialReviewersView extends AphrontView {
case DifferentialReviewerStatus::STATUS_COMMENTED:
if ($is_current) {
$item->setIcon(
'info-blue',
'info',
pht('Commented'));
} else {
$item->setIcon(
@ -87,7 +87,7 @@ final class DifferentialReviewersView extends AphrontView {
break;
default:
$item->setIcon('question-dark', pht('%s?', $reviewer->getStatus()));
$item->setIcon('question', pht('%s?', $reviewer->getStatus()));
break;
}

1
webroot/rsrc/css/phui/phui-property-list-view.css
View file

@ -60,7 +60,6 @@
.phui-property-list-value {
color: {$darkgreytext};
overflow: hidden;
line-height: 17px;
}

4
webroot/rsrc/css/phui/phui-status.css
View file

@ -6,6 +6,10 @@
width: 100%;
}
.phui-property-list-value .phui-status-list-view {
margin-left: -4px;
}
.phui-status-list-view .phui-icon-view {
display: block;
width: 14px;