From cdd5e3f7ddacadf37c382b73ec85e0d899405482 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 16 Oct 2015 06:39:31 -0700 Subject: [PATCH] Initialize `$assign_phid` properly in the "!assign" email action Summary: If you `!assign cahd` when you meant to `!assign chad`, we'll hit an "Undefined variable: assign_phid" a little further down. Test Plan: Eyeballed it. See IRC. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14291 --- .../maniphest/command/ManiphestAssignEmailCommand.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/maniphest/command/ManiphestAssignEmailCommand.php b/src/applications/maniphest/command/ManiphestAssignEmailCommand.php index 9d2a51b107..98e8a913a8 100644 --- a/src/applications/maniphest/command/ManiphestAssignEmailCommand.php +++ b/src/applications/maniphest/command/ManiphestAssignEmailCommand.php @@ -34,6 +34,7 @@ final class ManiphestAssignEmailCommand array $argv) { $xactions = array(); + $assign_phid = null; $assign_to = head($argv); if ($assign_to) {