From ce06a051a545afec811c34641e7a3d21fce8a0e7 Mon Sep 17 00:00:00 2001 From: Austin McKinley Date: Thu, 13 Apr 2017 13:01:18 -0700 Subject: [PATCH] Remove old Countdown route Summary: removes old phabricator.com/countdown/{id} route and code that uses that URL scheme Test Plan: loaded phabricator.com/countdown, verified that generated links point to phabricator.com/CXXX Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T12524 Differential Revision: https://secure.phabricator.com/D17681 --- .../countdown/application/PhabricatorCountdownApplication.php | 2 -- .../countdown/query/PhabricatorCountdownSearchEngine.php | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/applications/countdown/application/PhabricatorCountdownApplication.php b/src/applications/countdown/application/PhabricatorCountdownApplication.php index 2e7b8d1bbd..6cead5a01c 100644 --- a/src/applications/countdown/application/PhabricatorCountdownApplication.php +++ b/src/applications/countdown/application/PhabricatorCountdownApplication.php @@ -42,8 +42,6 @@ final class PhabricatorCountdownApplication extends PhabricatorApplication { '/countdown/' => array( '(?:query/(?P[^/]+)/)?' => 'PhabricatorCountdownListController', - '(?P[1-9]\d*)/' - => 'PhabricatorCountdownViewController', 'comment/(?P[1-9]\d*)/' => 'PhabricatorCountdownCommentController', $this->getEditRoutePattern('edit/') diff --git a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php index 00512cb07c..2f9fe9c0e8 100644 --- a/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php +++ b/src/applications/countdown/query/PhabricatorCountdownSearchEngine.php @@ -110,7 +110,7 @@ final class PhabricatorCountdownSearchEngine ->setObject($countdown) ->setObjectName($countdown->getMonogram()) ->setHeader($countdown->getTitle()) - ->setHref($this->getApplicationURI("{$id}/")) + ->setHref($countdown->getURI()) ->addByline( pht( 'Created by %s',