From ce2c0543bffac8b824577519c6ec62d47d01f4fe Mon Sep 17 00:00:00 2001 From: Dereckson Date: Fri, 12 Oct 2012 07:41:43 -0700 Subject: [PATCH] DifferentialCommentEditor::alterReviewers is now aware of differential.allow-self-accept setting Summary: This allows users to add a revision's author as reviewer according Differential configuration using the 'Leap Into Action' form. Test Plan: Tested on local install. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1885 Differential Revision: https://secure.phabricator.com/D3682 --- .../differential/editor/DifferentialCommentEditor.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/editor/DifferentialCommentEditor.php b/src/applications/differential/editor/DifferentialCommentEditor.php index db2e699410..8809d25f70 100644 --- a/src/applications/differential/editor/DifferentialCommentEditor.php +++ b/src/applications/differential/editor/DifferentialCommentEditor.php @@ -645,10 +645,12 @@ final class DifferentialCommentEditor extends PhabricatorEditor { $added_reviewers = $this->getAddedReviewers(); $removed_reviewers = $this->getRemovedReviewers(); $reviewer_phids = $revision->getReviewers(); + $allow_self_accept = PhabricatorEnv::getEnvConfig( + 'differential.allow-self-accept', false); $reviewer_phids_map = array_fill_keys($reviewer_phids, true); foreach ($added_reviewers as $k => $user_phid) { - if ($user_phid == $revision->getAuthorPHID()) { + if (!$allow_self_accept && $user_phid == $revision->getAuthorPHID()) { unset($added_reviewers[$k]); } if (isset($reviewer_phids_map[$user_phid])) {