From ce919b08229212a340bb0481d0c055fe1236ea49 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 8 Mar 2012 12:46:29 -0800
Subject: [PATCH] Resolve implicit fallthrough in Phabricator

Summary: New implicit fallthrough linter detected a few issues; none of these have behavioral impacts but they can clearly be tightened up. See D1824.

Test Plan: Lint; inspection.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1825
---
 scripts/repository/reparse.php                           | 3 ++-
 src/applications/phid/handle/PhabricatorObjectHandle.php | 1 +
 src/storage/qsprintf/qsprintf.php                        | 3 ++-
 webroot/index.php                                        | 2 +-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/scripts/repository/reparse.php b/scripts/repository/reparse.php
index c6849f7c79..9a755a0be8 100755
--- a/scripts/repository/reparse.php
+++ b/scripts/repository/reparse.php
@@ -2,7 +2,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -63,6 +63,7 @@ foreach ($args as $arg) {
         break;
       default:
         usage("Unknown flag '{$arg}'.");
+        break;
     }
   } else {
     if ($reparse_what) {
diff --git a/src/applications/phid/handle/PhabricatorObjectHandle.php b/src/applications/phid/handle/PhabricatorObjectHandle.php
index 1d3633c51c..95262f5486 100644
--- a/src/applications/phid/handle/PhabricatorObjectHandle.php
+++ b/src/applications/phid/handle/PhabricatorObjectHandle.php
@@ -223,6 +223,7 @@ class PhabricatorObjectHandle {
         break;
       default:
         $name = $this->getFullName();
+        break;
     }
     return $name;
   }
diff --git a/src/storage/qsprintf/qsprintf.php b/src/storage/qsprintf/qsprintf.php
index c2b41657d1..7fe0ef750d 100644
--- a/src/storage/qsprintf/qsprintf.php
+++ b/src/storage/qsprintf/qsprintf.php
@@ -1,7 +1,7 @@
 <?php
 
 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -264,6 +264,7 @@ function _qsprintf_check_type($value, $type, $query) {
       break;
     default:
       _qsprintf_check_scalar_type($value, $type, $query);
+      break;
   }
 }
 
diff --git a/webroot/index.php b/webroot/index.php
index afcc80fa0b..810ccdcf8b 100644
--- a/webroot/index.php
+++ b/webroot/index.php
@@ -220,7 +220,7 @@ function phabricator_detect_bad_base_uri() {
     case 'https':
       break;
     default:
-      phabricator_fatal_config_error(
+      return phabricator_fatal_config_error(
         "'phabricator.base-uri' is set to '{$conf}', which is invalid. ".
         "The URI must start with 'http://' or 'https://'.");
   }