revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fixed naming convention violations.

Browse source 
Summary: This file contains member variables prefixed with underscores. This violates the naming convention enforced by the linter.

Test Plan:
The linter warnings have disappeared. Example:
```
>>> Lint for src/infrastructure/storage/lisk/LiskDAO.php:

   Warning  (XHP9) Naming Conventions
    Follow naming conventions: class properties should be named using
    lowerCamelCase.

             183
             184   const COUNTER_TABLE_NAME          = 'lisk_counter';
             185
    >>>      186   private $__dirtyFields            = array();
             187   private $__missingFields          = array();
             188   private static $processIsolationLevel       = 0;
             189   private static $transactionIsolationLevel   = 0;
```

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8348
This commit is contained in:
Joshua Spence 2014-02-26 12:49:11 -08:00 committed by epriestley
parent 6270114767
commit cea58de0ba
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/infrastructure/storage/lisk/LiskDAO.php
View file

@ -183,12 +183,12 @@ abstract class LiskDAO {
const COUNTER_TABLE_NAME = 'lisk_counter';
private $__dirtyFields = array();
private $__missingFields = array();
private static $processIsolationLevel = 0;
private static $transactionIsolationLevel = 0;
private $dirtyFields = array();
private $missingFields = array();
private static $processIsolationLevel = 0;
private static $transactionIsolationLevel = 0;
private $__ephemeral = false;
private $ephemeral = false;
private static $connections = array();
@ -550,7 +550,7 @@ abstract class LiskDAO {
$columns[] = $this->getIDKey();
$properties = $this->getProperties();
$this->__missingFields = array_diff_key(
$this->missingFields = array_diff_key(
array_flip($properties),
array_flip($columns));
}
@ -1074,12 +1074,12 @@ abstract class LiskDAO {
* storage.
*/
public function makeEphemeral() {
$this->__ephemeral = true;
$this->ephemeral = true;
return $this;
}
private function isEphemeralCheck() {
if ($this->__ephemeral) {
if ($this->ephemeral) {
throw new LiskEphemeralObjectException();
}
}
@ -1144,7 +1144,7 @@ abstract class LiskDAO {
$this->willSaveObject();
$data = $this->getPropertyValues();
if ($this->getConfigOption(self::CONFIG_PARTIAL_OBJECTS)) {
$data = array_intersect_key($data, $this->__dirtyFields);
$data = array_intersect_key($data, $this->dirtyFields);
}
$this->willWriteData($data);
@ -1690,9 +1690,9 @@ abstract class LiskDAO {
* @task util
*/
private function resetDirtyFields() {
$this->__dirtyFields = array();
$this->dirtyFields = array();
if ($this->getConfigOption(self::CONFIG_TIMESTAMPS)) {
$this->__dirtyFields['dateModified'] = true;
$this->dirtyFields['dateModified'] = true;
}
}
@ -1741,7 +1741,7 @@ abstract class LiskDAO {
$dispatch_map[$method] = $property;
}
if ($partial && isset($this->__missingFields[$property])) {
if ($partial && isset($this->missingFields[$property])) {
throw new Exception("Cannot get field that wasn't loaded: {$property}");
}
@ -1764,8 +1764,8 @@ abstract class LiskDAO {
}
if ($partial) {
// Accept writes to fields that weren't initially loaded
unset($this->__missingFields[$property]);
$this->__dirtyFields[$property] = true;
unset($this->missingFields[$property]);
$this->dirtyFields[$property] = true;
}
$this->writeField($property, $args[0]);