From ceb395ea9bc30f88096ac2839a595a7967c5a919 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 Jul 2016 13:30:42 -0700 Subject: [PATCH] Don't link object monograms in object graphs Summary: Ref T4788. Test Plan: {F1708372} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16221 --- resources/celerity/map.php | 6 +++--- .../graph/DifferentialRevisionGraph.php | 14 ++++++++------ src/infrastructure/graph/ManiphestTaskGraph.php | 14 ++++++++------ webroot/rsrc/css/aphront/table-view.css | 7 ++++++- 4 files changed, 25 insertions(+), 16 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 999433e6d7..be152c24b9 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => 'd04e6f67', + 'core.pkg.css' => '55d9bb83', 'core.pkg.js' => 'f2139810', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => '3e81ae60', @@ -25,7 +25,7 @@ return array( 'rsrc/css/aphront/notification.css' => '3f6c89c9', 'rsrc/css/aphront/panel-view.css' => '8427b78d', 'rsrc/css/aphront/phabricator-nav-view.css' => 'ac79a758', - 'rsrc/css/aphront/table-view.css' => 'aeb66852', + 'rsrc/css/aphront/table-view.css' => '8df59783', 'rsrc/css/aphront/tokenizer.css' => '056da01b', 'rsrc/css/aphront/tooltip.css' => '1a07aea8', 'rsrc/css/aphront/typeahead-browse.css' => '8904346a', @@ -536,7 +536,7 @@ return array( 'aphront-list-filter-view-css' => '5d6f0526', 'aphront-multi-column-view-css' => 'fd18389d', 'aphront-panel-view-css' => '8427b78d', - 'aphront-table-view-css' => 'aeb66852', + 'aphront-table-view-css' => '8df59783', 'aphront-tokenizer-control-css' => '056da01b', 'aphront-tooltip-css' => '1a07aea8', 'aphront-typeahead-control-css' => 'd4f16145', diff --git a/src/infrastructure/graph/DifferentialRevisionGraph.php b/src/infrastructure/graph/DifferentialRevisionGraph.php index 0fba201ea1..3b5d638ec7 100644 --- a/src/infrastructure/graph/DifferentialRevisionGraph.php +++ b/src/infrastructure/graph/DifferentialRevisionGraph.php @@ -41,11 +41,13 @@ final class DifferentialRevisionGraph array( 'href' => $object->getURI(), ), - array( - $object->getMonogram(), - ' ', - $object->getTitle(), - )); + $object->getTitle()); + + $link = array( + $object->getMonogram(), + ' ', + $link, + ); } else { $status = null; $author = null; @@ -74,7 +76,7 @@ final class DifferentialRevisionGraph 'threads', 'graph-status', null, - 'wide object-link', + 'wide pri object-link', )); } diff --git a/src/infrastructure/graph/ManiphestTaskGraph.php b/src/infrastructure/graph/ManiphestTaskGraph.php index 769de28073..b793493cd3 100644 --- a/src/infrastructure/graph/ManiphestTaskGraph.php +++ b/src/infrastructure/graph/ManiphestTaskGraph.php @@ -54,11 +54,13 @@ final class ManiphestTaskGraph array( 'href' => $object->getURI(), ), - array( - $object->getMonogram(), - ' ', - $object->getTitle(), - )); + $object->getTitle()); + + $link = array( + $object->getMonogram(), + ' ', + $link, + ); } else { $status = null; $assigned = null; @@ -87,7 +89,7 @@ final class ManiphestTaskGraph 'threads', 'graph-status', null, - 'wide object-link', + 'wide pri object-link', )); } diff --git a/webroot/rsrc/css/aphront/table-view.css b/webroot/rsrc/css/aphront/table-view.css index 8ec4f2a4c6..dddd78f103 100644 --- a/webroot/rsrc/css/aphront/table-view.css +++ b/webroot/rsrc/css/aphront/table-view.css @@ -228,9 +228,14 @@ span.single-display-line-content { position: static; } +.aphront-table-view tr.closed td.object-link, +.aphront-table-view tr.alt-closed td.object-link { + text-decoration: line-through; + color: rgba({$alphablack}, 0.5); +} + .aphront-table-view tr.closed td.object-link a, .aphront-table-view tr.alt-closed td.object-link a { - text-decoration: line-through; color: rgba({$alphablack}, 0.5); }