revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Don't mark diff as "Unit Tests Skipped" when posponed test was skipped

Browse source 
Summary:
Following logic at https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/unit/ArcanistUnitWorkflow.php;ea0f737e85644d5a$242-255.

Also unrequire coverage.

Test Plan:
  echo '{"diff_id": 1, "file": "empty", "name": "name", "result": "skip", "message": "test"}' | arc call-conduit differential.updateunitresults

Reviewers: nh, epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2231
This commit is contained in:
vrana 2012-04-13 12:56:19 -07:00
parent ded641ae32
commit cec641a81e
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/conduit/method/differential/updateunitresults/ConduitAPI_differential_updateunitresults_Method.php
View file

@ -33,7 +33,7 @@ final class ConduitAPI_differential_updateunitresults_Method
'name' => 'required string', 'name' => 'required string',
'result' => 'required string', 'result' => 'required string',
'message' => 'required string', 'message' => 'required string',
'coverage' => 'required map<string, string>', 'coverage' => 'map<string, string>',
); );
} }
@ -124,15 +124,16 @@ final class ConduitAPI_differential_updateunitresults_Method
DifferentialUnitTestResult::RESULT_FAIL => DifferentialUnitTestResult::RESULT_FAIL =>
DifferentialUnitStatus::UNIT_FAIL, DifferentialUnitStatus::UNIT_FAIL,
DifferentialUnitTestResult::RESULT_SKIP => DifferentialUnitTestResult::RESULT_SKIP =>
DifferentialUnitStatus::UNIT_SKIP, DifferentialUnitStatus::UNIT_OKAY,
DifferentialUnitTestResult::RESULT_POSTPONED => DifferentialUnitTestResult::RESULT_POSTPONED =>
DifferentialUnitStatus::UNIT_POSTPONED); DifferentialUnitStatus::UNIT_POSTPONED);
if ($diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) { if ($diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) {
$status_code =
idx($status_codes, $unit_status, DifferentialUnitStatus::UNIT_NONE);
if ($postponed_count == 0 || if ($postponed_count == 0 ||
$unit_status != DifferentialUnitTestResult::RESULT_PASS) { $status_code != DifferentialUnitStatus::UNIT_OKAY) {
$diff->setUnitStatus( $diff->setUnitStatus($status_code);
idx($status_codes, $unit_status, DifferentialUnitStatus::UNIT_NONE));
$diff->save(); $diff->save();
} }
} }