revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-02 02:40:58 +01:00
Code Issues Releases Wiki Activity

Fix an issue with clearing cookies when a cookie prefix is set

Browse source 
Summary: If a cookie prefix is set (as on the Phacility cluster), we end up double-namespacing cookies when trying to remove them. This can make logging out produce a cookie error.

Test Plan: Logged out locally with cookie prefix, got normal logout workflow.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11282
This commit is contained in:
epriestley 2015-01-08 16:24:34 -08:00
parent 4aea5325fd
commit cecc08756e
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/aphront/AphrontRequest.php
View file

@ -333,7 +333,6 @@ final class AphrontRequest {
} }
final public function clearCookie($name) { final public function clearCookie($name) {
$name = $this->getPrefixedCookieName($name);
$this->setCookieWithExpiration($name, '', time() - (60 * 60 * 24 * 30)); $this->setCookieWithExpiration($name, '', time() - (60 * 60 * 24 * 30));
unset($_COOKIE[$name]); unset($_COOKIE[$name]);
} }