From cefdca164422632fb36e9d922bc762f2a83b6515 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 7 Apr 2015 11:57:35 -0700 Subject: [PATCH] Fix two minor CSS states with Done button Summary: Fixes T7737, gets rid of not-done hover yellow, and removed the pointer on button-done state for reviewer. Test Plan: tested numerous states as reviewer and author. Rechecked done on a few items. Verify new states work. This still seems fragile. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7737 Differential Revision: https://secure.phabricator.com/D12313 --- resources/celerity/map.php | 4 ++-- .../css/application/differential/phui-inline-comment.css | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index b2dabf0f8f..b8f401fa4a 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -57,7 +57,7 @@ return array( 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e', 'rsrc/css/application/differential/core.css' => '7ac3cabc', - 'rsrc/css/application/differential/phui-inline-comment.css' => '7277be53', + 'rsrc/css/application/differential/phui-inline-comment.css' => 'b7860d00', 'rsrc/css/application/differential/results-table.css' => '181aa9d9', 'rsrc/css/application/differential/revision-comment.css' => '024dda6b', 'rsrc/css/application/differential/revision-history.css' => '0e8eb855', @@ -790,7 +790,7 @@ return array( 'phui-image-mask-css' => '5a8b09c8', 'phui-info-panel-css' => '27ea50a1', 'phui-info-view-css' => 'c6f0aef8', - 'phui-inline-comment-view-css' => '7277be53', + 'phui-inline-comment-view-css' => 'b7860d00', 'phui-list-view-css' => '2e25ebfb', 'phui-object-box-css' => 'd68ce5dc', 'phui-object-item-list-view-css' => '9db65899', diff --git a/webroot/rsrc/css/application/differential/phui-inline-comment.css b/webroot/rsrc/css/application/differential/phui-inline-comment.css index 9f500c475f..7666c1dad4 100644 --- a/webroot/rsrc/css/application/differential/phui-inline-comment.css +++ b/webroot/rsrc/css/application/differential/phui-inline-comment.css @@ -274,8 +274,8 @@ } .device-desktop .differential-inline-comment.inline-state-is-draft - .button-not-done:hover { - color: {$lightgreytext} !important; + .differential-inline-comment-head .button.simple.button-not-done:hover { + color: {$lightgreytext}; background-color: transparent; border-color: {$lightgreyborder}; cursor: auto; @@ -294,6 +294,7 @@ background-color: #fff; color: {$sky}; border-color: {$sky}; + cursor: auto; } .differential-inline-comment.inline-is-done .differential-inline-comment-head