From cfea1d29ee422331be4370246d2715779e4a71e8 Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 17 Sep 2012 11:44:03 -0700 Subject: [PATCH] Unuse short ternary operator Summary: We still support PHP 5.2. Test Plan: $ arc lint Reviewers: nh, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D3503 --- .../panel/PhabricatorSettingsPanelDisplayPreferences.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php index 5d78441ca0..7d713128b7 100644 --- a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php +++ b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php @@ -75,6 +75,8 @@ EXAMPLE; $font_default = PhabricatorEnv::getEnvConfig('style.monospace'); $font_default = phutil_escape_html($font_default); + $pref_symbols_value = $preferences->getPreference($pref_symbols); + $form = id(new AphrontFormView()) ->setUser($user) ->appendChild( @@ -117,7 +119,7 @@ EXAMPLE; id(new AphrontFormRadioButtonControl()) ->setLabel('Symbol Links') ->setName($pref_symbols) - ->setValue($preferences->getPreference($pref_symbols) ?: 'enabled') + ->setValue($pref_symbols_value ? $pref_symbols_value : 'enabled') ->addButton('enabled', 'Enabled (default)', 'Use this setting to disable linking symbol names in Differential '. 'and Diffusion to their definitions. This is enabled by default.')