revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Remove very old "vsDiff" data from commit update / diff extraction pipeline

Browse source 
Summary:
Ref T13276. This was introduced in D2586 to power a "trigger audits when the committed change does not match the reviewed change" feature. It was removed without ceremony in D15939. Broadly, rebases mean that this sort of feature can't really work like this and this approach is inherently unreliable; see also T182.

This property no longer has readers, and is unlikely to get any in the future since my planned pathway for "committed code must match reviewed code, modulo an automated rebase" is automating the rebase via "Land Revision", not comparing the diff text.

Remove this to simplify the flow of data here so that things in T13276 can be fixed more easily.

Test Plan: Grepped for `vsDiff`, no hits.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13276

Differential Revision: https://secure.phabricator.com/D20395
This commit is contained in:
epriestley 2019-04-11 06:03:16 -07:00
parent 0f9776fb58
commit d02256df3c
2 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
View file

@ -243,8 +243,6 @@ final class DifferentialDiffExtractionEngine extends Phobject {
PhabricatorContentSource $content_source) {
$viewer = $this->getViewer();
$result_data = array();
$new_diff = $this->newDiffFromCommit($commit);
$old_diff = $revision->getActiveDiff();
@ -261,8 +259,6 @@ final class DifferentialDiffExtractionEngine extends Phobject {
$old_diff,
$new_diff);
if ($has_changed) {
$result_data['vsDiff'] = $old_diff->getID();
$revision_monogram = $revision->getMonogram();
$old_id = $old_diff->getID();
$new_id = $new_diff->getID();
@ -336,8 +332,6 @@ final class DifferentialDiffExtractionEngine extends Phobject {
// lost a race to close the revision. That's perfectly fine, we can
// just continue normally.
}
return $result_data;
}
private function loadConcerningBuilds(DifferentialRevision $revision) {

6
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -278,17 +278,13 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$content_source = $this->newContentSource();
$update_data = $extraction_engine->updateRevisionWithCommit(
$extraction_engine->updateRevisionWithCommit(
$revision,
$commit,
array(
$commit_close_xaction,
),
$content_source);
foreach ($update_data as $key => $value) {
$data->setCommitDetail($key, $value);
}
}
}
}