From d0258a89817530faa66013345eeccbef728cccbf Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 2 Feb 2017 06:01:41 -0800 Subject: [PATCH] Fix a mismatched method definition in PhabricatorHomeProfileMenuItem Summary: Fixes T12187. Ref T12190. See T12190 for discussion of why this escaped notice. Test Plan: - Commented out the `error_reporting()` clause around file inclusion. - Reproduced the error in PHP7. - Corrected the method signature. - Reloaded the page, no more error. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12190, T12187 Differential Revision: https://secure.phabricator.com/D17297 --- .../home/menuitem/PhabricatorHomeProfileMenuItem.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php b/src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php index ec0147c78c..8b3eb4fe2d 100644 --- a/src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php +++ b/src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php @@ -29,7 +29,8 @@ final class PhabricatorHomeProfileMenuItem return $this->getDefaultName(); } - public function newPageContent() { + public function newPageContent( + PhabricatorProfileMenuItemConfiguration $config) { $viewer = $this->getViewer(); return id(new PHUIHomeView())