revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 13:52:40 +01:00
Code Issues Releases Wiki Activity

Wrap the feed text rendering stuff with htmlspecialchars_decode

Browse source 
Summary: I've only seen this be an issue with PhabricatorBot.

Test Plan: Comment on something with characters that are automatically converted like "<>", and see what the irc bot reports

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D8140
This commit is contained in:
Korvin Szanto 2014-02-03 17:05:16 -08:00 committed by epriestley
parent 30b9503b85
commit d02b106dc6
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/tokens/feed/PhabricatorTokenGivenFeedStory.php
View file

@ -44,7 +44,11 @@ final class PhabricatorTokenGivenFeedStory
public function renderText() {
// TODO: This is grotesque; the feed notification handler relies on it.
return strip_tags(hsprintf('%s', $this->renderView()->render()));
return htmlspecialchars_decode(
strip_tags(
hsprintf(
'%s',
$this->renderView()->render())));
}
}

6
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
View file

@ -66,7 +66,11 @@ class PhabricatorApplicationTransactionFeedStory
public function renderText() {
// TODO: This is grotesque; the feed notification handler relies on it.
return strip_tags(hsprintf('%s', $this->renderView()->render()));
return htmlspecialchars_decode(
strip_tags(
hsprintf(
'%s',
$this->renderView()->render())));
}
}