Add "final" to (almost) everything else

Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually. Test Plan: Ran testEverythingImplemented. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1881
2025-03-24 18:20:14 +01:00 · 2012-03-13 16:21:04 -07:00 · 2012-03-13 16:21:04 -07:00 · d0af617818
commit d0af617818
parent 7c9057854b
182 changed files with 318 additions and 305 deletions
--- a/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php
+++ b/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,6 +16,9 @@
 * limitations under the License.
 */

+/**
+ * TODO: Can we final this?
+ */
 class DatabaseConfigurationProvider {
  private $dao;
  private $mode;
--- a/src/applications/conduit/storage/methodcalllog/PhabricatorConduitMethodCallLog.php
+++ b/src/applications/conduit/storage/methodcalllog/PhabricatorConduitMethodCallLog.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group conduit
 */
-class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO {
+final class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO {

  protected $connectionID;
  protected $method;
--- a/src/applications/herald/adapter/commit/HeraldCommitAdapter.php
+++ b/src/applications/herald/adapter/commit/HeraldCommitAdapter.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldCommitAdapter extends HeraldObjectAdapter {
+final class HeraldCommitAdapter extends HeraldObjectAdapter {

  protected $diff;
  protected $revision;
--- a/src/applications/herald/adapter/differential/HeraldDifferentialRevisionAdapter.php
+++ b/src/applications/herald/adapter/differential/HeraldDifferentialRevisionAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldDifferentialRevisionAdapter extends HeraldObjectAdapter {
+final class HeraldDifferentialRevisionAdapter extends HeraldObjectAdapter {

  protected $revision;
  protected $diff;
--- a/src/applications/herald/adapter/dryrun/HeraldDryRunAdapter.php
+++ b/src/applications/herald/adapter/dryrun/HeraldDryRunAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldDryRunAdapter extends HeraldObjectAdapter {
+final class HeraldDryRunAdapter extends HeraldObjectAdapter {

  public function getPHID() {
    return 0;
--- a/src/applications/herald/config/action/HeraldActionConfig.php
+++ b/src/applications/herald/config/action/HeraldActionConfig.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldActionConfig {
+final class HeraldActionConfig {

  const ACTION_ADD_CC       = 'addcc';
  const ACTION_REMOVE_CC    = 'remcc';
--- a/src/applications/herald/config/condition/HeraldConditionConfig.php
+++ b/src/applications/herald/config/condition/HeraldConditionConfig.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldConditionConfig {
+final class HeraldConditionConfig {

  const CONDITION_CONTAINS        = 'contains';
  const CONDITION_NOT_CONTAINS    = '!contains';
--- a/src/applications/herald/config/contenttype/HeraldContentTypeConfig.php
+++ b/src/applications/herald/config/contenttype/HeraldContentTypeConfig.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldContentTypeConfig {
+final class HeraldContentTypeConfig {

  const CONTENT_TYPE_DIFFERENTIAL = 'differential';
  const CONTENT_TYPE_COMMIT       = 'commit';
--- a/src/applications/herald/config/field/HeraldFieldConfig.php
+++ b/src/applications/herald/config/field/HeraldFieldConfig.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldFieldConfig {
+final class HeraldFieldConfig {

  const FIELD_TITLE                  = 'title';
  const FIELD_BODY                   = 'body';
--- a/src/applications/herald/config/repetitionpolicy/HeraldRepetitionPolicyConfig.php
+++ b/src/applications/herald/config/repetitionpolicy/HeraldRepetitionPolicyConfig.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRepetitionPolicyConfig {
+final class HeraldRepetitionPolicyConfig {
  const FIRST   = 'first';  // only execute the first time (no repeating)
  const EVERY   = 'every';  // repeat every time

--- a/src/applications/herald/config/ruletype/HeraldRuleTypeConfig.php
+++ b/src/applications/herald/config/ruletype/HeraldRuleTypeConfig.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRuleTypeConfig {
+final class HeraldRuleTypeConfig {

  const RULE_TYPE_GLOBAL = 'global';
  const RULE_TYPE_PERSONAL = 'personal';
--- a/src/applications/herald/config/valuetype/HeraldValueTypeConfig.php
+++ b/src/applications/herald/config/valuetype/HeraldValueTypeConfig.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldValueTypeConfig {
+final class HeraldValueTypeConfig {

  const VALUE_TEXT                = 'text';
  const VALUE_NONE                = 'none';
--- a/src/applications/herald/engine/effect/HeraldEffect.php
+++ b/src/applications/herald/engine/effect/HeraldEffect.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldEffect {
+final class HeraldEffect {

  protected $objectPHID;
  protected $action;
--- a/src/applications/herald/engine/engine/HeraldEngine.php
+++ b/src/applications/herald/engine/engine/HeraldEngine.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldEngine {
+final class HeraldEngine {

  protected $rules = array();
  protected $results = array();
--- a/src/applications/herald/engine/engine/exception/HeraldInvalidConditionException.php
+++ b/src/applications/herald/engine/engine/exception/HeraldInvalidConditionException.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
 * limitations under the License.
 */

-class HeraldInvalidConditionException extends Exception {}
+final class HeraldInvalidConditionException extends Exception {}
--- a/src/applications/herald/engine/engine/exception/HeraldInvalidFieldException.php
+++ b/src/applications/herald/engine/engine/exception/HeraldInvalidFieldException.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
 * limitations under the License.
 */

-class HeraldInvalidFieldException extends Exception {}
+final class HeraldInvalidFieldException extends Exception {}
--- a/src/applications/herald/engine/engine/exception/HeraldRecursiveConditionsException.php
+++ b/src/applications/herald/engine/engine/exception/HeraldRecursiveConditionsException.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
 * limitations under the License.
 */

-class HeraldRecursiveConditionsException extends Exception {}
+final class HeraldRecursiveConditionsException extends Exception {}
--- a/src/applications/herald/storage/action/HeraldAction.php
+++ b/src/applications/herald/storage/action/HeraldAction.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldAction extends HeraldDAO {
+final class HeraldAction extends HeraldDAO {

  protected $ruleID;

--- a/src/applications/herald/storage/condition/HeraldCondition.php
+++ b/src/applications/herald/storage/condition/HeraldCondition.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldCondition extends HeraldDAO {
+final class HeraldCondition extends HeraldDAO {

  protected $ruleID;

--- a/src/applications/herald/storage/edithistory/HeraldRuleEdit.php
+++ b/src/applications/herald/storage/edithistory/HeraldRuleEdit.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRuleEdit extends HeraldDAO {
+final class HeraldRuleEdit extends HeraldDAO {

  protected $editorPHID;
  protected $ruleID;
--- a/src/applications/herald/storage/rule/HeraldRule.php
+++ b/src/applications/herald/storage/rule/HeraldRule.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRule extends HeraldDAO {
+final class HeraldRule extends HeraldDAO {

  const TABLE_RULE_APPLIED = 'herald_ruleapplied';

--- a/src/applications/herald/storage/transcript/apply/HeraldApplyTranscript.php
+++ b/src/applications/herald/storage/transcript/apply/HeraldApplyTranscript.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldApplyTranscript extends HeraldDAO {
+final class HeraldApplyTranscript extends HeraldDAO {

  protected $action;
  protected $target;
--- a/src/applications/herald/storage/transcript/base/HeraldTranscript.php
+++ b/src/applications/herald/storage/transcript/base/HeraldTranscript.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldTranscript extends HeraldDAO {
+final class HeraldTranscript extends HeraldDAO {

  protected $id;
  protected $phid;
--- a/src/applications/herald/storage/transcript/condition/HeraldConditionTranscript.php
+++ b/src/applications/herald/storage/transcript/condition/HeraldConditionTranscript.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldConditionTranscript {
+final class HeraldConditionTranscript {

  protected $ruleID;
  protected $conditionID;
--- a/src/applications/herald/storage/transcript/object/HeraldObjectTranscript.php
+++ b/src/applications/herald/storage/transcript/object/HeraldObjectTranscript.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldObjectTranscript {
+final class HeraldObjectTranscript {

  protected $phid;
  protected $type;
--- a/src/applications/herald/storage/transcript/rule/HeraldRuleTranscript.php
+++ b/src/applications/herald/storage/transcript/rule/HeraldRuleTranscript.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class HeraldRuleTranscript {
+final class HeraldRuleTranscript {

  protected $ruleID;
  protected $result;
--- a/src/applications/maniphest/auxiliaryfield/typeexception/ManiphestAuxiliaryFieldTypeException.php
+++ b/src/applications/maniphest/auxiliaryfield/typeexception/ManiphestAuxiliaryFieldTypeException.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
 /**
 * @group maniphest
 */
-class ManiphestAuxiliaryFieldTypeException extends Exception {
+final class ManiphestAuxiliaryFieldTypeException extends Exception {

 }
--- a/src/applications/maniphest/auxiliaryfield/validationexception/ManiphestAuxiliaryFieldValidationException.php
+++ b/src/applications/maniphest/auxiliaryfield/validationexception/ManiphestAuxiliaryFieldValidationException.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
 /**
 * @group maniphest
 */
-class ManiphestAuxiliaryFieldValidationException extends Exception {
+final class ManiphestAuxiliaryFieldValidationException extends Exception {

 }
--- a/src/applications/maniphest/constants/action/ManiphestAction.php
+++ b/src/applications/maniphest/constants/action/ManiphestAction.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestAction extends PhrictionConstants {
+final class ManiphestAction extends PhrictionConstants {

  const ACTION_CREATE   = 'create';
  const ACTION_CLOSE    = 'close';
--- a/src/applications/maniphest/constants/base/ManiphestConstants.php
+++ b/src/applications/maniphest/constants/base/ManiphestConstants.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
 /**
 * @group maniphest
 */
-class ManiphestConstants {
+abstract class ManiphestConstants {

 }
--- a/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php
+++ b/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransactionEditor {
+final class ManiphestTransactionEditor {

  private $parentMessageID;
  private $auxiliaryFields = array();
--- a/src/applications/maniphest/replyhandler/ManiphestReplyHandler.php
+++ b/src/applications/maniphest/replyhandler/ManiphestReplyHandler.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestReplyHandler extends PhabricatorMailReplyHandler {
+final class ManiphestReplyHandler extends PhabricatorMailReplyHandler {

  public function validateMailReceiver($mail_receiver) {
    if (!($mail_receiver instanceof ManiphestTask)) {
--- a/src/applications/maniphest/storage/auxiliary/ManiphestTaskAuxiliaryStorage.php
+++ b/src/applications/maniphest/storage/auxiliary/ManiphestTaskAuxiliaryStorage.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskAuxiliaryStorage extends ManiphestDAO {
+final class ManiphestTaskAuxiliaryStorage extends ManiphestDAO {

  protected $taskPHID;
  protected $name;
--- a/src/applications/maniphest/storage/base/ManiphestDAO.php
+++ b/src/applications/maniphest/storage/base/ManiphestDAO.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestDAO extends PhabricatorLiskDAO {
+abstract class ManiphestDAO extends PhabricatorLiskDAO {

  public function getApplicationName() {
    return 'maniphest';
--- a/src/applications/maniphest/storage/task/ManiphestTask.php
+++ b/src/applications/maniphest/storage/task/ManiphestTask.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTask extends ManiphestDAO {
+final class ManiphestTask extends ManiphestDAO {

  protected $phid;
  protected $authorPHID;
--- a/src/applications/maniphest/storage/transaction/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/transaction/ManiphestTransaction.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransaction extends ManiphestDAO {
+final class ManiphestTransaction extends ManiphestDAO {

  protected $taskID;
  protected $authorPHID;
--- a/src/applications/maniphest/view/tasklist/ManiphestTaskListView.php
+++ b/src/applications/maniphest/view/tasklist/ManiphestTaskListView.php
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskListView extends ManiphestView {
+final class ManiphestTaskListView extends ManiphestView {

  private $tasks;
  private $handles;
--- a/src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php
+++ b/src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTaskSummaryView extends ManiphestView {
+final class ManiphestTaskSummaryView extends ManiphestView {

  private $task;
  private $handles;
--- a/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php
+++ b/src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransactionDetailView extends ManiphestView {
+final class ManiphestTransactionDetailView extends ManiphestView {

  private $transactions;
  private $handles;
--- a/src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
+++ b/src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
@ -19,7 +19,7 @@
 /**
 * @group maniphest
 */
-class ManiphestTransactionListView extends ManiphestView {
+final class ManiphestTransactionListView extends ManiphestView {

  private $transactions;
  private $handles;
--- a/src/applications/metamta/adapter/amazonses/PhabricatorMailImplementationAmazonSESAdapter.php
+++ b/src/applications/metamta/adapter/amazonses/PhabricatorMailImplementationAmazonSESAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMailImplementationAmazonSESAdapter
+final class PhabricatorMailImplementationAmazonSESAdapter
  extends PhabricatorMailImplementationPHPMailerLiteAdapter {

  private $message;
--- a/src/applications/metamta/adapter/phpmailerlite/PhabricatorMailImplementationPHPMailerLiteAdapter.php
+++ b/src/applications/metamta/adapter/phpmailerlite/PhabricatorMailImplementationPHPMailerLiteAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,6 +16,9 @@
 * limitations under the License.
 */

+/**
+ * TODO: Should be final, but inherited by SES.
+ */
 class PhabricatorMailImplementationPHPMailerLiteAdapter
  extends PhabricatorMailImplementationAdapter {

--- a/src/applications/metamta/adapter/sendgrid/PhabricatorMailImplementationSendGridAdapter.php
+++ b/src/applications/metamta/adapter/sendgrid/PhabricatorMailImplementationSendGridAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * Mail adapter that uses SendGrid's web API to deliver email.
 */
-class PhabricatorMailImplementationSendGridAdapter
+final class PhabricatorMailImplementationSendGridAdapter
  extends PhabricatorMailImplementationAdapter {

  private $params = array();
--- a/src/applications/metamta/adapter/test/PhabricatorMailImplementationTestAdapter.php
+++ b/src/applications/metamta/adapter/test/PhabricatorMailImplementationTestAdapter.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -20,7 +20,7 @@
 * Mail adapter that doesn't actually send any email, for writing unit tests
 * against.
 */
-class PhabricatorMailImplementationTestAdapter
+final class PhabricatorMailImplementationTestAdapter
  extends PhabricatorMailImplementationAdapter {

  private $guts = array();
--- a/src/applications/metamta/storage/mail/PhabricatorMetaMTAAttachment.php
+++ b/src/applications/metamta/storage/mail/PhabricatorMetaMTAAttachment.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAAttachment {
+final class PhabricatorMetaMTAAttachment {
  protected $data;
  protected $filename;
  protected $mimetype;
--- a/src/applications/metamta/storage/mail/PhabricatorMetaMTAMail.php
+++ b/src/applications/metamta/storage/mail/PhabricatorMetaMTAMail.php
@ -19,7 +19,7 @@
 /**
 * See #394445 for an explanation of why this thing even exists.
 */
-class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
+final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {

  const STATUS_QUEUE = 'queued';
  const STATUS_SENT  = 'sent';
--- a/src/applications/metamta/storage/mail/tests/PhabricatorMetaMTAMailTestCase.php
+++ b/src/applications/metamta/storage/mail/tests/PhabricatorMetaMTAMailTestCase.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
+final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {

  public function testThreadIDHeaders() {
    $this->runThreadIDHeadersWithConfiguration(true, true);
--- a/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php
+++ b/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAMailingList extends PhabricatorMetaMTADAO {
+final class PhabricatorMetaMTAMailingList extends PhabricatorMetaMTADAO {

  protected $name;
  protected $phid;
--- a/src/applications/metamta/storage/receivedmail/PhabricatorMetaMTAReceivedMail.php
+++ b/src/applications/metamta/storage/receivedmail/PhabricatorMetaMTAReceivedMail.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {
+final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {

  protected $headers = array();
  protected $bodies = array();
--- a/src/applications/owners/query/path/PhabricatorOwnerPathQuery.php
+++ b/src/applications/owners/query/path/PhabricatorOwnerPathQuery.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOwnerPathQuery {
+final class PhabricatorOwnerPathQuery {

  public static function loadAffectedPaths(
    PhabricatorRepository $repository,
--- a/src/applications/owners/storage/owner/PhabricatorOwnersOwner.php
+++ b/src/applications/owners/storage/owner/PhabricatorOwnersOwner.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOwnersOwner extends PhabricatorOwnersDAO {
+final class PhabricatorOwnersOwner extends PhabricatorOwnersDAO {

  protected $packageID;
  protected $userPHID;
--- a/src/applications/owners/storage/package/PhabricatorOwnersPackage.php
+++ b/src/applications/owners/storage/package/PhabricatorOwnersPackage.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOwnersPackage extends PhabricatorOwnersDAO {
+final class PhabricatorOwnersPackage extends PhabricatorOwnersDAO {

  protected $phid;
  protected $name;
--- a/src/applications/owners/storage/path/PhabricatorOwnersPath.php
+++ b/src/applications/owners/storage/path/PhabricatorOwnersPath.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorOwnersPath extends PhabricatorOwnersDAO {
+final class PhabricatorOwnersPath extends PhabricatorOwnersDAO {

  protected $packageID;
  protected $repositoryPHID;
--- a/src/applications/paste/storage/paste/PhabricatorPaste.php
+++ b/src/applications/paste/storage/paste/PhabricatorPaste.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorPaste extends PhabricatorPasteDAO {
+final class PhabricatorPaste extends PhabricatorPasteDAO {

  protected $phid;
  protected $title;
--- a/src/applications/people/storage/log/PhabricatorUserLog.php
+++ b/src/applications/people/storage/log/PhabricatorUserLog.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUserLog extends PhabricatorUserDAO {
+final class PhabricatorUserLog extends PhabricatorUserDAO {

  const ACTION_LOGIN          = 'login';
  const ACTION_LOGOUT         = 'logout';
--- a/src/applications/people/storage/preferences/PhabricatorUserPreferences.php
+++ b/src/applications/people/storage/preferences/PhabricatorUserPreferences.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUserPreferences extends PhabricatorUserDAO {
+final class PhabricatorUserPreferences extends PhabricatorUserDAO {

  const PREFERENCE_MONOSPACED     = 'monospaced';
  const PREFERENCE_EDITOR         = 'editor';
--- a/src/applications/people/storage/profile/PhabricatorUserProfile.php
+++ b/src/applications/people/storage/profile/PhabricatorUserProfile.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUserProfile extends PhabricatorUserDAO {
+final class PhabricatorUserProfile extends PhabricatorUserDAO {

  protected $userPHID;
  protected $title;
--- a/src/applications/people/storage/user/PhabricatorUser.php
+++ b/src/applications/people/storage/user/PhabricatorUser.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUser extends PhabricatorUserDAO {
+final class PhabricatorUser extends PhabricatorUserDAO {

  const SESSION_TABLE = 'phabricator_session';
  const NAMETOKEN_TABLE = 'user_nametoken';
--- a/src/applications/people/storage/useroauthinfo/PhabricatorUserOAuthInfo.php
+++ b/src/applications/people/storage/useroauthinfo/PhabricatorUserOAuthInfo.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUserOAuthInfo extends PhabricatorUserDAO {
+final class PhabricatorUserOAuthInfo extends PhabricatorUserDAO {

  const TOKEN_STATUS_NONE     = 'none';
  const TOKEN_STATUS_GOOD     = 'good';
--- a/src/applications/people/storage/usersshkey/PhabricatorUserSSHKey.php
+++ b/src/applications/people/storage/usersshkey/PhabricatorUserSSHKey.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorUserSSHKey extends PhabricatorUserDAO {
+final class PhabricatorUserSSHKey extends PhabricatorUserDAO {

  protected $userPHID;
  protected $name;
--- a/src/applications/phid/handle/PhabricatorObjectHandle.php
+++ b/src/applications/phid/handle/PhabricatorObjectHandle.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorObjectHandle {
+final class PhabricatorObjectHandle {

  private $uri;
  private $phid;
--- a/src/applications/phid/handle/const/status/PhabricatorObjectHandleStatus.php
+++ b/src/applications/phid/handle/const/status/PhabricatorObjectHandleStatus.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorObjectHandleStatus
+final class PhabricatorObjectHandleStatus
  extends PhabricatorObjectHandleConstants {

  const STATUS_OPEN   = 'open';
--- a/src/applications/phid/handle/data/PhabricatorObjectHandleData.php
+++ b/src/applications/phid/handle/data/PhabricatorObjectHandleData.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorObjectHandleData {
+final class PhabricatorObjectHandleData {

  private $phids;

--- a/src/applications/phid/handle/view/selector/PhabricatorHandleObjectSelectorDataView.php
+++ b/src/applications/phid/handle/view/selector/PhabricatorHandleObjectSelectorDataView.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorHandleObjectSelectorDataView {
+final class PhabricatorHandleObjectSelectorDataView {

  private $handle;

--- a/src/applications/phid/storage/base/PhabricatorPHIDDAO.php
+++ b/src/applications/phid/storage/base/PhabricatorPHIDDAO.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorPHIDDAO extends PhabricatorLiskDAO {
+abstract class PhabricatorPHIDDAO extends PhabricatorLiskDAO {

  public function getApplicationName() {
    return 'phid';
--- a/src/applications/phid/storage/phid/PhabricatorPHID.php
+++ b/src/applications/phid/storage/phid/PhabricatorPHID.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorPHID extends PhabricatorPHIDDAO {
+final class PhabricatorPHID extends PhabricatorPHIDDAO {

  protected $phid;
  protected $phidType;
--- a/src/applications/phriction/constants/action/PhrictionActionConstants.php
+++ b/src/applications/phriction/constants/action/PhrictionActionConstants.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group phriction
 */
-class PhrictionActionConstants extends PhrictionConstants {
+final class PhrictionActionConstants extends PhrictionConstants {

  const ACTION_CREATE   = 'create';
  const ACTION_EDIT     = 'edit';
--- a/src/applications/phriction/storage/content/PhrictionContent.php
+++ b/src/applications/phriction/storage/content/PhrictionContent.php
@ -19,7 +19,7 @@
 /**
 * @group phriction
 */
-class PhrictionContent extends PhrictionDAO {
+final class PhrictionContent extends PhrictionDAO {

  protected $id;
  protected $documentID;
--- a/src/applications/phriction/storage/document/PhrictionDocument.php
+++ b/src/applications/phriction/storage/document/PhrictionDocument.php
@ -19,7 +19,7 @@
 /**
 * @group phriction
 */
-class PhrictionDocument extends PhrictionDAO {
+final class PhrictionDocument extends PhrictionDAO {

  protected $id;
  protected $phid;
--- a/src/applications/phriction/storage/document/tests/PhrictionDocumentTestCase.php
+++ b/src/applications/phriction/storage/document/tests/PhrictionDocumentTestCase.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group phriction
 */
-class PhrictionDocumentTestCase extends PhabricatorTestCase {
+final class PhrictionDocumentTestCase extends PhabricatorTestCase {

  public function testSlugNormalization() {
    $slugs = array(
--- a/src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php
+++ b/src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorProjectAffiliation extends PhabricatorProjectDAO {
+final class PhabricatorProjectAffiliation extends PhabricatorProjectDAO {

  protected $projectPHID;
  protected $userPHID;
--- a/src/applications/project/storage/base/PhabricatorProjectDAO.php
+++ b/src/applications/project/storage/base/PhabricatorProjectDAO.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorProjectDAO extends PhabricatorLiskDAO {
+abstract class PhabricatorProjectDAO extends PhabricatorLiskDAO {

  public function getApplicationName() {
    return 'project';
--- a/src/applications/project/storage/profile/PhabricatorProjectProfile.php
+++ b/src/applications/project/storage/profile/PhabricatorProjectProfile.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorProjectProfile extends PhabricatorProjectDAO {
+final class PhabricatorProjectProfile extends PhabricatorProjectDAO {

  protected $projectPHID;
  protected $blurb;
--- a/src/applications/project/storage/project/PhabricatorProject.php
+++ b/src/applications/project/storage/project/PhabricatorProject.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorProject extends PhabricatorProjectDAO {
+final class PhabricatorProject extends PhabricatorProjectDAO {

  protected $name;
  protected $phid;
--- a/src/applications/project/storage/transaction/PhabricatorProjectTransaction.php
+++ b/src/applications/project/storage/transaction/PhabricatorProjectTransaction.php
@ -19,7 +19,7 @@
 /**
 * @group project
 */
-class PhabricatorProjectTransaction extends PhabricatorProjectDAO {
+final class PhabricatorProjectTransaction extends PhabricatorProjectDAO {

  protected $projectID;
  protected $authorPHID;
--- a/src/applications/repository/daemon/commitdiscovery/git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php
+++ b/src/applications/repository/daemon/commitdiscovery/git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryGitCommitDiscoveryDaemon
+final class PhabricatorRepositoryGitCommitDiscoveryDaemon
  extends PhabricatorRepositoryCommitDiscoveryDaemon {

  protected function discoverCommits() {
--- a/src/applications/repository/daemon/commitdiscovery/mercurial/PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php
+++ b/src/applications/repository/daemon/commitdiscovery/mercurial/PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryMercurialCommitDiscoveryDaemon
+final class PhabricatorRepositoryMercurialCommitDiscoveryDaemon
  extends PhabricatorRepositoryCommitDiscoveryDaemon {

  protected function discoverCommits() {
--- a/src/applications/repository/daemon/commitdiscovery/svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php
+++ b/src/applications/repository/daemon/commitdiscovery/svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositorySvnCommitDiscoveryDaemon
+final class PhabricatorRepositorySvnCommitDiscoveryDaemon
  extends PhabricatorRepositoryCommitDiscoveryDaemon {

  protected function discoverCommits() {
--- a/src/applications/repository/daemon/committask/PhabricatorRepositoryCommitTaskDaemon.php
+++ b/src/applications/repository/daemon/committask/PhabricatorRepositoryCommitTaskDaemon.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryCommitTaskDaemon
+final class PhabricatorRepositoryCommitTaskDaemon
  extends PhabricatorRepositoryDaemon {

  final public function run() {
--- a/src/applications/repository/parser/default/PhabricatorRepositoryDefaultCommitMessageDetailParser.php
+++ b/src/applications/repository/parser/default/PhabricatorRepositoryDefaultCommitMessageDetailParser.php
@ -16,6 +16,9 @@
 * limitations under the License.
 */

+/**
+ * TODO: Facebook extends this (I think?), but should it?
+ */
 class PhabricatorRepositoryDefaultCommitMessageDetailParser
  extends PhabricatorRepositoryCommitMessageDetailParser {

--- a/src/applications/repository/storage/arcanistproject/PhabricatorRepositoryArcanistProject.php
+++ b/src/applications/repository/storage/arcanistproject/PhabricatorRepositoryArcanistProject.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryArcanistProject
+final class PhabricatorRepositoryArcanistProject
  extends PhabricatorRepositoryDAO {

  protected $name;
--- a/src/applications/repository/storage/base/PhabricatorRepositoryDAO.php
+++ b/src/applications/repository/storage/base/PhabricatorRepositoryDAO.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryDAO extends PhabricatorLiskDAO {
+abstract class PhabricatorRepositoryDAO extends PhabricatorLiskDAO {

  public function getApplicationName() {
    return 'repository';
--- a/src/applications/repository/storage/commit/PhabricatorRepositoryCommit.php
+++ b/src/applications/repository/storage/commit/PhabricatorRepositoryCommit.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryCommit extends PhabricatorRepositoryDAO {
+final class PhabricatorRepositoryCommit extends PhabricatorRepositoryDAO {

  protected $repositoryID;
  protected $phid;
--- a/src/applications/repository/storage/commitdata/PhabricatorRepositoryCommitData.php
+++ b/src/applications/repository/storage/commitdata/PhabricatorRepositoryCommitData.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryCommitData extends PhabricatorRepositoryDAO {
+final class PhabricatorRepositoryCommitData extends PhabricatorRepositoryDAO {

  const SUMMARY_MAX_LENGTH = 100;

--- a/src/applications/repository/storage/repository/PhabricatorRepository.php
+++ b/src/applications/repository/storage/repository/PhabricatorRepository.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepository extends PhabricatorRepositoryDAO {
+final class PhabricatorRepository extends PhabricatorRepositoryDAO {

  const TABLE_PATH = 'repository_path';
  const TABLE_PATHCHANGE = 'repository_pathchange';
--- a/src/applications/repository/storage/shortcut/PhabricatorRepositoryShortcut.php
+++ b/src/applications/repository/storage/shortcut/PhabricatorRepositoryShortcut.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryShortcut extends PhabricatorRepositoryDAO {
+final class PhabricatorRepositoryShortcut extends PhabricatorRepositoryDAO {

  protected $name;
  protected $href;
--- a/src/applications/repository/storage/symbol/PhabricatorRepositorySymbol.php
+++ b/src/applications/repository/storage/symbol/PhabricatorRepositorySymbol.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,6 @@
 * limitations under the License.
 */

-
 /**
 * Records information about symbol locations in a codebase, like where classes
 * and functions are defined.
@ -25,7 +24,7 @@
 *
 * @group diffusion
 */
-class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO {
+final class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO {

  protected $arcanistProjectID;
  protected $symbolName;
--- a/src/applications/repository/worker/commitchangeparser/git/PhabricatorRepositoryGitCommitChangeParserWorker.php
+++ b/src/applications/repository/worker/commitchangeparser/git/PhabricatorRepositoryGitCommitChangeParserWorker.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryGitCommitChangeParserWorker
+final class PhabricatorRepositoryGitCommitChangeParserWorker
  extends PhabricatorRepositoryCommitChangeParserWorker {

  protected function parseCommit(
--- a/src/applications/repository/worker/commitchangeparser/mercurial/PhabricatorRepositoryMercurialCommitChangeParserWorker.php
+++ b/src/applications/repository/worker/commitchangeparser/mercurial/PhabricatorRepositoryMercurialCommitChangeParserWorker.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryMercurialCommitChangeParserWorker
+final class PhabricatorRepositoryMercurialCommitChangeParserWorker
  extends PhabricatorRepositoryCommitChangeParserWorker {

  protected function parseCommit(
--- a/src/applications/repository/worker/commitmessageparser/git/PhabricatorRepositoryGitCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/git/PhabricatorRepositoryGitCommitMessageParserWorker.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryGitCommitMessageParserWorker
+final class PhabricatorRepositoryGitCommitMessageParserWorker
  extends PhabricatorRepositoryCommitMessageParserWorker {

  public function parseCommit(
--- a/src/applications/repository/worker/commitmessageparser/mercurial/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/mercurial/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryMercurialCommitMessageParserWorker
+final class PhabricatorRepositoryMercurialCommitMessageParserWorker
  extends PhabricatorRepositoryCommitMessageParserWorker {

  public function parseCommit(
--- a/src/applications/repository/worker/commitmessageparser/svn/PhabricatorRepositorySvnCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/svn/PhabricatorRepositorySvnCommitMessageParserWorker.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositorySvnCommitMessageParserWorker
+final class PhabricatorRepositorySvnCommitMessageParserWorker
  extends PhabricatorRepositoryCommitMessageParserWorker {

  public function parseCommit(
--- a/src/applications/repository/worker/herald/PhabricatorRepositoryCommitHeraldWorker.php
+++ b/src/applications/repository/worker/herald/PhabricatorRepositoryCommitHeraldWorker.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryCommitHeraldWorker
+final class PhabricatorRepositoryCommitHeraldWorker
  extends PhabricatorRepositoryCommitParserWorker {

  public function parseCommit(
--- a/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php
+++ b/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php
@ -16,7 +16,7 @@
 * limitations under the License.
 */

-class PhabricatorRepositoryCommitOwnersWorker
+final class PhabricatorRepositoryCommitOwnersWorker
  extends PhabricatorRepositoryCommitParserWorker {

  protected function parseCommit(
--- a/src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
+++ b/src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchDifferentialIndexer
+final class PhabricatorSearchDifferentialIndexer
  extends PhabricatorSearchDocumentIndexer {

  public static function indexRevision(DifferentialRevision $rev) {
--- a/src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php
+++ b/src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchManiphestIndexer
+final class PhabricatorSearchManiphestIndexer
  extends PhabricatorSearchDocumentIndexer {

  public static function indexTask(ManiphestTask $task) {
--- a/src/applications/search/index/indexer/phriction/PhabricatorSearchPhrictionIndexer.php
+++ b/src/applications/search/index/indexer/phriction/PhabricatorSearchPhrictionIndexer.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchPhrictionIndexer
+final class PhabricatorSearchPhrictionIndexer
  extends PhabricatorSearchDocumentIndexer {

  public static function indexDocument(PhrictionDocument $document) {
--- a/src/applications/search/index/indexer/repository/PhabricatorSearchCommitIndexer.php
+++ b/src/applications/search/index/indexer/repository/PhabricatorSearchCommitIndexer.php
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchCommitIndexer
+final class PhabricatorSearchCommitIndexer
  extends PhabricatorSearchDocumentIndexer {

  public static function indexCommit(PhabricatorRepositoryCommit $commit) {
--- a/src/applications/search/index/indexer/user/PhabricatorSearchUserIndexer.php
+++ b/src/applications/search/index/indexer/user/PhabricatorSearchUserIndexer.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchUserIndexer
+final class PhabricatorSearchUserIndexer
  extends PhabricatorSearchDocumentIndexer {

  public static function indexUser(PhabricatorUser $user) {
--- a/src/applications/search/storage/document/document/PhabricatorSearchDocument.php
+++ b/src/applications/search/storage/document/document/PhabricatorSearchDocument.php
@ -1,7 +1,7 @@
 <?php

 /*
- * Copyright 2011 Facebook, Inc.
+ * Copyright 2012 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
 /**
 * @group search
 */
-class PhabricatorSearchDocument extends PhabricatorSearchDAO {
+final class PhabricatorSearchDocument extends PhabricatorSearchDAO {

  protected $phid;
  protected $documentType;
--- a/Show more
+++ b/Show more