revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-28 12:08:14 +01:00
Code Issues Releases Wiki Activity

Add "final" to (almost) everything else

Browse source 
Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually.

Test Plan: Ran testEverythingImplemented.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1881
This commit is contained in:
epriestley 2012-03-13 16:21:04 -07:00
parent 7c9057854b
commit d0af617818
182 changed files with 318 additions and 305 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/base/storage/configuration/DatabaseConfigurationProvider.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,9 @@
* limitations under the License. * limitations under the License.
*/ */
/**
* TODO: Can we final this?
*/
class DatabaseConfigurationProvider { class DatabaseConfigurationProvider {
private $dao; private $dao;
private $mode; private $mode;

4
src/applications/conduit/storage/methodcalllog/PhabricatorConduitMethodCallLog.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group conduit * @group conduit
*/ */
class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO { final class PhabricatorConduitMethodCallLog extends PhabricatorConduitDAO {
protected $connectionID; protected $connectionID;
protected $method; protected $method;

2
src/applications/herald/adapter/commit/HeraldCommitAdapter.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldCommitAdapter extends HeraldObjectAdapter { final class HeraldCommitAdapter extends HeraldObjectAdapter {
protected $diff; protected $diff;
protected $revision; protected $revision;

4
src/applications/herald/adapter/differential/HeraldDifferentialRevisionAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldDifferentialRevisionAdapter extends HeraldObjectAdapter { final class HeraldDifferentialRevisionAdapter extends HeraldObjectAdapter {
protected $revision; protected $revision;
protected $diff; protected $diff;

4
src/applications/herald/adapter/dryrun/HeraldDryRunAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldDryRunAdapter extends HeraldObjectAdapter { final class HeraldDryRunAdapter extends HeraldObjectAdapter {
public function getPHID() { public function getPHID() {
return 0; return 0;

2
src/applications/herald/config/action/HeraldActionConfig.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldActionConfig { final class HeraldActionConfig {
const ACTION_ADD_CC = 'addcc'; const ACTION_ADD_CC = 'addcc';
const ACTION_REMOVE_CC = 'remcc'; const ACTION_REMOVE_CC = 'remcc';

2
src/applications/herald/config/condition/HeraldConditionConfig.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldConditionConfig { final class HeraldConditionConfig {
const CONDITION_CONTAINS = 'contains'; const CONDITION_CONTAINS = 'contains';
const CONDITION_NOT_CONTAINS = '!contains'; const CONDITION_NOT_CONTAINS = '!contains';

4
src/applications/herald/config/contenttype/HeraldContentTypeConfig.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldContentTypeConfig { final class HeraldContentTypeConfig {
const CONTENT_TYPE_DIFFERENTIAL = 'differential'; const CONTENT_TYPE_DIFFERENTIAL = 'differential';
const CONTENT_TYPE_COMMIT = 'commit'; const CONTENT_TYPE_COMMIT = 'commit';

2
src/applications/herald/config/field/HeraldFieldConfig.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldFieldConfig { final class HeraldFieldConfig {
const FIELD_TITLE = 'title'; const FIELD_TITLE = 'title';
const FIELD_BODY = 'body'; const FIELD_BODY = 'body';

4
src/applications/herald/config/repetitionpolicy/HeraldRepetitionPolicyConfig.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRepetitionPolicyConfig { final class HeraldRepetitionPolicyConfig {
const FIRST = 'first'; // only execute the first time (no repeating) const FIRST = 'first'; // only execute the first time (no repeating)
const EVERY = 'every'; // repeat every time const EVERY = 'every'; // repeat every time

2
src/applications/herald/config/ruletype/HeraldRuleTypeConfig.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRuleTypeConfig { final class HeraldRuleTypeConfig {
const RULE_TYPE_GLOBAL = 'global'; const RULE_TYPE_GLOBAL = 'global';
const RULE_TYPE_PERSONAL = 'personal'; const RULE_TYPE_PERSONAL = 'personal';

2
src/applications/herald/config/valuetype/HeraldValueTypeConfig.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldValueTypeConfig { final class HeraldValueTypeConfig {
const VALUE_TEXT = 'text'; const VALUE_TEXT = 'text';
const VALUE_NONE = 'none'; const VALUE_NONE = 'none';

4
src/applications/herald/engine/effect/HeraldEffect.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldEffect { final class HeraldEffect {
protected $objectPHID; protected $objectPHID;
protected $action; protected $action;

2
src/applications/herald/engine/engine/HeraldEngine.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldEngine { final class HeraldEngine {
protected $rules = array(); protected $rules = array();
protected $results = array(); protected $results = array();

4
src/applications/herald/engine/engine/exception/HeraldInvalidConditionException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldInvalidConditionException extends Exception {} final class HeraldInvalidConditionException extends Exception {}

4
src/applications/herald/engine/engine/exception/HeraldInvalidFieldException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldInvalidFieldException extends Exception {} final class HeraldInvalidFieldException extends Exception {}

4
src/applications/herald/engine/engine/exception/HeraldRecursiveConditionsException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,4 +16,4 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRecursiveConditionsException extends Exception {} final class HeraldRecursiveConditionsException extends Exception {}

4
src/applications/herald/storage/action/HeraldAction.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldAction extends HeraldDAO { final class HeraldAction extends HeraldDAO {
protected $ruleID; protected $ruleID;

4
src/applications/herald/storage/condition/HeraldCondition.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldCondition extends HeraldDAO { final class HeraldCondition extends HeraldDAO {
protected $ruleID; protected $ruleID;

2
src/applications/herald/storage/edithistory/HeraldRuleEdit.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRuleEdit extends HeraldDAO { final class HeraldRuleEdit extends HeraldDAO {
protected $editorPHID; protected $editorPHID;
protected $ruleID; protected $ruleID;

2
src/applications/herald/storage/rule/HeraldRule.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRule extends HeraldDAO { final class HeraldRule extends HeraldDAO {
const TABLE_RULE_APPLIED = 'herald_ruleapplied'; const TABLE_RULE_APPLIED = 'herald_ruleapplied';

4
src/applications/herald/storage/transcript/apply/HeraldApplyTranscript.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldApplyTranscript extends HeraldDAO { final class HeraldApplyTranscript extends HeraldDAO {
protected $action; protected $action;
protected $target; protected $target;

4
src/applications/herald/storage/transcript/base/HeraldTranscript.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldTranscript extends HeraldDAO { final class HeraldTranscript extends HeraldDAO {
protected $id; protected $id;
protected $phid; protected $phid;

4
src/applications/herald/storage/transcript/condition/HeraldConditionTranscript.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldConditionTranscript { final class HeraldConditionTranscript {
protected $ruleID; protected $ruleID;
protected $conditionID; protected $conditionID;

4
src/applications/herald/storage/transcript/object/HeraldObjectTranscript.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldObjectTranscript { final class HeraldObjectTranscript {
protected $phid; protected $phid;
protected $type; protected $type;

4
src/applications/herald/storage/transcript/rule/HeraldRuleTranscript.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class HeraldRuleTranscript { final class HeraldRuleTranscript {
protected $ruleID; protected $ruleID;
protected $result; protected $result;

4
src/applications/maniphest/auxiliaryfield/typeexception/ManiphestAuxiliaryFieldTypeException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestAuxiliaryFieldTypeException extends Exception { final class ManiphestAuxiliaryFieldTypeException extends Exception {
} }

4
src/applications/maniphest/auxiliaryfield/validationexception/ManiphestAuxiliaryFieldValidationException.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestAuxiliaryFieldValidationException extends Exception { final class ManiphestAuxiliaryFieldValidationException extends Exception {
} }

4
src/applications/maniphest/constants/action/ManiphestAction.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestAction extends PhrictionConstants { final class ManiphestAction extends PhrictionConstants {
const ACTION_CREATE = 'create'; const ACTION_CREATE = 'create';
const ACTION_CLOSE = 'close'; const ACTION_CLOSE = 'close';

4
src/applications/maniphest/constants/base/ManiphestConstants.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,6 +19,6 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestConstants { abstract class ManiphestConstants {
} }

2
src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTransactionEditor { final class ManiphestTransactionEditor {
private $parentMessageID; private $parentMessageID;
private $auxiliaryFields = array(); private $auxiliaryFields = array();

4
src/applications/maniphest/replyhandler/ManiphestReplyHandler.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestReplyHandler extends PhabricatorMailReplyHandler { final class ManiphestReplyHandler extends PhabricatorMailReplyHandler {
public function validateMailReceiver($mail_receiver) { public function validateMailReceiver($mail_receiver) {
if (!($mail_receiver instanceof ManiphestTask)) { if (!($mail_receiver instanceof ManiphestTask)) {

4
src/applications/maniphest/storage/auxiliary/ManiphestTaskAuxiliaryStorage.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTaskAuxiliaryStorage extends ManiphestDAO { final class ManiphestTaskAuxiliaryStorage extends ManiphestDAO {
protected $taskPHID; protected $taskPHID;
protected $name; protected $name;

4
src/applications/maniphest/storage/base/ManiphestDAO.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestDAO extends PhabricatorLiskDAO { abstract class ManiphestDAO extends PhabricatorLiskDAO {
public function getApplicationName() { public function getApplicationName() {
return 'maniphest'; return 'maniphest';

4
src/applications/maniphest/storage/task/ManiphestTask.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTask extends ManiphestDAO { final class ManiphestTask extends ManiphestDAO {
protected $phid; protected $phid;
protected $authorPHID; protected $authorPHID;

4
src/applications/maniphest/storage/transaction/ManiphestTransaction.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTransaction extends ManiphestDAO { final class ManiphestTransaction extends ManiphestDAO {
protected $taskID; protected $taskID;
protected $authorPHID; protected $authorPHID;

2
src/applications/maniphest/view/tasklist/ManiphestTaskListView.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTaskListView extends ManiphestView { final class ManiphestTaskListView extends ManiphestView {
private $tasks; private $tasks;
private $handles; private $handles;

2
src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTaskSummaryView extends ManiphestView { final class ManiphestTaskSummaryView extends ManiphestView {
private $task; private $task;
private $handles; private $handles;

2
src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTransactionDetailView extends ManiphestView { final class ManiphestTransactionDetailView extends ManiphestView {
private $transactions; private $transactions;
private $handles; private $handles;

2
src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
View file

@ -19,7 +19,7 @@
/** /**
* @group maniphest * @group maniphest
*/ */
class ManiphestTransactionListView extends ManiphestView { final class ManiphestTransactionListView extends ManiphestView {
private $transactions; private $transactions;
private $handles; private $handles;

4
src/applications/metamta/adapter/amazonses/PhabricatorMailImplementationAmazonSESAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorMailImplementationAmazonSESAdapter final class PhabricatorMailImplementationAmazonSESAdapter
extends PhabricatorMailImplementationPHPMailerLiteAdapter { extends PhabricatorMailImplementationPHPMailerLiteAdapter {
private $message; private $message;

5
src/applications/metamta/adapter/phpmailerlite/PhabricatorMailImplementationPHPMailerLiteAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,9 @@
* limitations under the License. * limitations under the License.
*/ */
/**
* TODO: Should be final, but inherited by SES.
*/
class PhabricatorMailImplementationPHPMailerLiteAdapter class PhabricatorMailImplementationPHPMailerLiteAdapter
extends PhabricatorMailImplementationAdapter { extends PhabricatorMailImplementationAdapter {

4
src/applications/metamta/adapter/sendgrid/PhabricatorMailImplementationSendGridAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* Mail adapter that uses SendGrid's web API to deliver email. * Mail adapter that uses SendGrid's web API to deliver email.
*/ */
class PhabricatorMailImplementationSendGridAdapter final class PhabricatorMailImplementationSendGridAdapter
extends PhabricatorMailImplementationAdapter { extends PhabricatorMailImplementationAdapter {
private $params = array(); private $params = array();

4
src/applications/metamta/adapter/test/PhabricatorMailImplementationTestAdapter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -20,7 +20,7 @@
* Mail adapter that doesn't actually send any email, for writing unit tests * Mail adapter that doesn't actually send any email, for writing unit tests
* against. * against.
*/ */
class PhabricatorMailImplementationTestAdapter final class PhabricatorMailImplementationTestAdapter
extends PhabricatorMailImplementationAdapter { extends PhabricatorMailImplementationAdapter {
private $guts = array(); private $guts = array();

2
src/applications/metamta/storage/mail/PhabricatorMetaMTAAttachment.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorMetaMTAAttachment { final class PhabricatorMetaMTAAttachment {
protected $data; protected $data;
protected $filename; protected $filename;
protected $mimetype; protected $mimetype;

2
src/applications/metamta/storage/mail/PhabricatorMetaMTAMail.php
View file

@ -19,7 +19,7 @@
/** /**
* See #394445 for an explanation of why this thing even exists. * See #394445 for an explanation of why this thing even exists.
*/ */
class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO { final class PhabricatorMetaMTAMail extends PhabricatorMetaMTADAO {
const STATUS_QUEUE = 'queued'; const STATUS_QUEUE = 'queued';
const STATUS_SENT = 'sent'; const STATUS_SENT = 'sent';

4
src/applications/metamta/storage/mail/__tests__/PhabricatorMetaMTAMailTestCase.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase { final class PhabricatorMetaMTAMailTestCase extends PhabricatorTestCase {
public function testThreadIDHeaders() { public function testThreadIDHeaders() {
$this->runThreadIDHeadersWithConfiguration(true, true); $this->runThreadIDHeadersWithConfiguration(true, true);

4
src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorMetaMTAMailingList extends PhabricatorMetaMTADAO { final class PhabricatorMetaMTAMailingList extends PhabricatorMetaMTADAO {
protected $name; protected $name;
protected $phid; protected $phid;

2
src/applications/metamta/storage/receivedmail/PhabricatorMetaMTAReceivedMail.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO { final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {
protected $headers = array(); protected $headers = array();
protected $bodies = array(); protected $bodies = array();

4
src/applications/owners/query/path/PhabricatorOwnerPathQuery.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOwnerPathQuery { final class PhabricatorOwnerPathQuery {
public static function loadAffectedPaths( public static function loadAffectedPaths(
PhabricatorRepository $repository, PhabricatorRepository $repository,

4
src/applications/owners/storage/owner/PhabricatorOwnersOwner.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOwnersOwner extends PhabricatorOwnersDAO { final class PhabricatorOwnersOwner extends PhabricatorOwnersDAO {
protected $packageID; protected $packageID;
protected $userPHID; protected $userPHID;

4
src/applications/owners/storage/package/PhabricatorOwnersPackage.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOwnersPackage extends PhabricatorOwnersDAO { final class PhabricatorOwnersPackage extends PhabricatorOwnersDAO {
protected $phid; protected $phid;
protected $name; protected $name;

4
src/applications/owners/storage/path/PhabricatorOwnersPath.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorOwnersPath extends PhabricatorOwnersDAO { final class PhabricatorOwnersPath extends PhabricatorOwnersDAO {
protected $packageID; protected $packageID;
protected $repositoryPHID; protected $repositoryPHID;

4
src/applications/paste/storage/paste/PhabricatorPaste.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorPaste extends PhabricatorPasteDAO { final class PhabricatorPaste extends PhabricatorPasteDAO {
protected $phid; protected $phid;
protected $title; protected $title;

2
src/applications/people/storage/log/PhabricatorUserLog.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUserLog extends PhabricatorUserDAO { final class PhabricatorUserLog extends PhabricatorUserDAO {
const ACTION_LOGIN = 'login'; const ACTION_LOGIN = 'login';
const ACTION_LOGOUT = 'logout'; const ACTION_LOGOUT = 'logout';

2
src/applications/people/storage/preferences/PhabricatorUserPreferences.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUserPreferences extends PhabricatorUserDAO { final class PhabricatorUserPreferences extends PhabricatorUserDAO {
const PREFERENCE_MONOSPACED = 'monospaced'; const PREFERENCE_MONOSPACED = 'monospaced';
const PREFERENCE_EDITOR = 'editor'; const PREFERENCE_EDITOR = 'editor';

4
src/applications/people/storage/profile/PhabricatorUserProfile.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUserProfile extends PhabricatorUserDAO { final class PhabricatorUserProfile extends PhabricatorUserDAO {
protected $userPHID; protected $userPHID;
protected $title; protected $title;

2
src/applications/people/storage/user/PhabricatorUser.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUser extends PhabricatorUserDAO { final class PhabricatorUser extends PhabricatorUserDAO {
const SESSION_TABLE = 'phabricator_session'; const SESSION_TABLE = 'phabricator_session';
const NAMETOKEN_TABLE = 'user_nametoken'; const NAMETOKEN_TABLE = 'user_nametoken';

4
src/applications/people/storage/useroauthinfo/PhabricatorUserOAuthInfo.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUserOAuthInfo extends PhabricatorUserDAO { final class PhabricatorUserOAuthInfo extends PhabricatorUserDAO {
const TOKEN_STATUS_NONE = 'none'; const TOKEN_STATUS_NONE = 'none';
const TOKEN_STATUS_GOOD = 'good'; const TOKEN_STATUS_GOOD = 'good';

2
src/applications/people/storage/usersshkey/PhabricatorUserSSHKey.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorUserSSHKey extends PhabricatorUserDAO { final class PhabricatorUserSSHKey extends PhabricatorUserDAO {
protected $userPHID; protected $userPHID;
protected $name; protected $name;

2
src/applications/phid/handle/PhabricatorObjectHandle.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorObjectHandle { final class PhabricatorObjectHandle {
private $uri; private $uri;
private $phid; private $phid;

4
src/applications/phid/handle/const/status/PhabricatorObjectHandleStatus.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorObjectHandleStatus final class PhabricatorObjectHandleStatus
extends PhabricatorObjectHandleConstants { extends PhabricatorObjectHandleConstants {
const STATUS_OPEN = 'open'; const STATUS_OPEN = 'open';

2
src/applications/phid/handle/data/PhabricatorObjectHandleData.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorObjectHandleData { final class PhabricatorObjectHandleData {
private $phids; private $phids;

4
src/applications/phid/handle/view/selector/PhabricatorHandleObjectSelectorDataView.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorHandleObjectSelectorDataView { final class PhabricatorHandleObjectSelectorDataView {
private $handle; private $handle;

4
src/applications/phid/storage/base/PhabricatorPHIDDAO.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorPHIDDAO extends PhabricatorLiskDAO { abstract class PhabricatorPHIDDAO extends PhabricatorLiskDAO {
public function getApplicationName() { public function getApplicationName() {
return 'phid'; return 'phid';

4
src/applications/phid/storage/phid/PhabricatorPHID.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorPHID extends PhabricatorPHIDDAO { final class PhabricatorPHID extends PhabricatorPHIDDAO {
protected $phid; protected $phid;
protected $phidType; protected $phidType;

4
src/applications/phriction/constants/action/PhrictionActionConstants.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group phriction * @group phriction
*/ */
class PhrictionActionConstants extends PhrictionConstants { final class PhrictionActionConstants extends PhrictionConstants {
const ACTION_CREATE = 'create'; const ACTION_CREATE = 'create';
const ACTION_EDIT = 'edit'; const ACTION_EDIT = 'edit';

2
src/applications/phriction/storage/content/PhrictionContent.php
View file

@ -19,7 +19,7 @@
/** /**
* @group phriction * @group phriction
*/ */
class PhrictionContent extends PhrictionDAO { final class PhrictionContent extends PhrictionDAO {
protected $id; protected $id;
protected $documentID; protected $documentID;

2
src/applications/phriction/storage/document/PhrictionDocument.php
View file

@ -19,7 +19,7 @@
/** /**
* @group phriction * @group phriction
*/ */
class PhrictionDocument extends PhrictionDAO { final class PhrictionDocument extends PhrictionDAO {
protected $id; protected $id;
protected $phid; protected $phid;

4
src/applications/phriction/storage/document/__tests__/PhrictionDocumentTestCase.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group phriction * @group phriction
*/ */
class PhrictionDocumentTestCase extends PhabricatorTestCase { final class PhrictionDocumentTestCase extends PhabricatorTestCase {
public function testSlugNormalization() { public function testSlugNormalization() {
$slugs = array( $slugs = array(

4
src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorProjectAffiliation extends PhabricatorProjectDAO { final class PhabricatorProjectAffiliation extends PhabricatorProjectDAO {
protected $projectPHID; protected $projectPHID;
protected $userPHID; protected $userPHID;

4
src/applications/project/storage/base/PhabricatorProjectDAO.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorProjectDAO extends PhabricatorLiskDAO { abstract class PhabricatorProjectDAO extends PhabricatorLiskDAO {
public function getApplicationName() { public function getApplicationName() {
return 'project'; return 'project';

4
src/applications/project/storage/profile/PhabricatorProjectProfile.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorProjectProfile extends PhabricatorProjectDAO { final class PhabricatorProjectProfile extends PhabricatorProjectDAO {
protected $projectPHID; protected $projectPHID;
protected $blurb; protected $blurb;

2
src/applications/project/storage/project/PhabricatorProject.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorProject extends PhabricatorProjectDAO { final class PhabricatorProject extends PhabricatorProjectDAO {
protected $name; protected $name;
protected $phid; protected $phid;

2
src/applications/project/storage/transaction/PhabricatorProjectTransaction.php
View file

@ -19,7 +19,7 @@
/** /**
* @group project * @group project
*/ */
class PhabricatorProjectTransaction extends PhabricatorProjectDAO { final class PhabricatorProjectTransaction extends PhabricatorProjectDAO {
protected $projectID; protected $projectID;
protected $authorPHID; protected $authorPHID;

2
src/applications/repository/daemon/commitdiscovery/git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryGitCommitDiscoveryDaemon final class PhabricatorRepositoryGitCommitDiscoveryDaemon
extends PhabricatorRepositoryCommitDiscoveryDaemon { extends PhabricatorRepositoryCommitDiscoveryDaemon {
protected function discoverCommits() { protected function discoverCommits() {

4
src/applications/repository/daemon/commitdiscovery/mercurial/PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryMercurialCommitDiscoveryDaemon final class PhabricatorRepositoryMercurialCommitDiscoveryDaemon
extends PhabricatorRepositoryCommitDiscoveryDaemon { extends PhabricatorRepositoryCommitDiscoveryDaemon {
protected function discoverCommits() { protected function discoverCommits() {

4
src/applications/repository/daemon/commitdiscovery/svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositorySvnCommitDiscoveryDaemon final class PhabricatorRepositorySvnCommitDiscoveryDaemon
extends PhabricatorRepositoryCommitDiscoveryDaemon { extends PhabricatorRepositoryCommitDiscoveryDaemon {
protected function discoverCommits() { protected function discoverCommits() {

4
src/applications/repository/daemon/committask/PhabricatorRepositoryCommitTaskDaemon.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryCommitTaskDaemon final class PhabricatorRepositoryCommitTaskDaemon
extends PhabricatorRepositoryDaemon { extends PhabricatorRepositoryDaemon {
final public function run() { final public function run() {

3
src/applications/repository/parser/default/PhabricatorRepositoryDefaultCommitMessageDetailParser.php
View file

@ -16,6 +16,9 @@
* limitations under the License. * limitations under the License.
*/ */
/**
* TODO: Facebook extends this (I think?), but should it?
*/
class PhabricatorRepositoryDefaultCommitMessageDetailParser class PhabricatorRepositoryDefaultCommitMessageDetailParser
extends PhabricatorRepositoryCommitMessageDetailParser { extends PhabricatorRepositoryCommitMessageDetailParser {

4
src/applications/repository/storage/arcanistproject/PhabricatorRepositoryArcanistProject.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryArcanistProject final class PhabricatorRepositoryArcanistProject
extends PhabricatorRepositoryDAO { extends PhabricatorRepositoryDAO {
protected $name; protected $name;

4
src/applications/repository/storage/base/PhabricatorRepositoryDAO.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryDAO extends PhabricatorLiskDAO { abstract class PhabricatorRepositoryDAO extends PhabricatorLiskDAO {
public function getApplicationName() { public function getApplicationName() {
return 'repository'; return 'repository';

2
src/applications/repository/storage/commit/PhabricatorRepositoryCommit.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryCommit extends PhabricatorRepositoryDAO { final class PhabricatorRepositoryCommit extends PhabricatorRepositoryDAO {
protected $repositoryID; protected $repositoryID;
protected $phid; protected $phid;

4
src/applications/repository/storage/commitdata/PhabricatorRepositoryCommitData.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryCommitData extends PhabricatorRepositoryDAO { final class PhabricatorRepositoryCommitData extends PhabricatorRepositoryDAO {
const SUMMARY_MAX_LENGTH = 100; const SUMMARY_MAX_LENGTH = 100;

2
src/applications/repository/storage/repository/PhabricatorRepository.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepository extends PhabricatorRepositoryDAO { final class PhabricatorRepository extends PhabricatorRepositoryDAO {
const TABLE_PATH = 'repository_path'; const TABLE_PATH = 'repository_path';
const TABLE_PATHCHANGE = 'repository_pathchange'; const TABLE_PATHCHANGE = 'repository_pathchange';

4
src/applications/repository/storage/shortcut/PhabricatorRepositoryShortcut.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryShortcut extends PhabricatorRepositoryDAO { final class PhabricatorRepositoryShortcut extends PhabricatorRepositoryDAO {
protected $name; protected $name;
protected $href; protected $href;

5
src/applications/repository/storage/symbol/PhabricatorRepositorySymbol.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,6 @@
* limitations under the License. * limitations under the License.
*/ */
/** /**
* Records information about symbol locations in a codebase, like where classes * Records information about symbol locations in a codebase, like where classes
* and functions are defined. * and functions are defined.
@ -25,7 +24,7 @@
* *
* @group diffusion * @group diffusion
*/ */
class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO { final class PhabricatorRepositorySymbol extends PhabricatorRepositoryDAO {
protected $arcanistProjectID; protected $arcanistProjectID;
protected $symbolName; protected $symbolName;

2
src/applications/repository/worker/commitchangeparser/git/PhabricatorRepositoryGitCommitChangeParserWorker.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryGitCommitChangeParserWorker final class PhabricatorRepositoryGitCommitChangeParserWorker
extends PhabricatorRepositoryCommitChangeParserWorker { extends PhabricatorRepositoryCommitChangeParserWorker {
protected function parseCommit( protected function parseCommit(

4
src/applications/repository/worker/commitchangeparser/mercurial/PhabricatorRepositoryMercurialCommitChangeParserWorker.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryMercurialCommitChangeParserWorker final class PhabricatorRepositoryMercurialCommitChangeParserWorker
extends PhabricatorRepositoryCommitChangeParserWorker { extends PhabricatorRepositoryCommitChangeParserWorker {
protected function parseCommit( protected function parseCommit(

2
src/applications/repository/worker/commitmessageparser/git/PhabricatorRepositoryGitCommitMessageParserWorker.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryGitCommitMessageParserWorker final class PhabricatorRepositoryGitCommitMessageParserWorker
extends PhabricatorRepositoryCommitMessageParserWorker { extends PhabricatorRepositoryCommitMessageParserWorker {
public function parseCommit( public function parseCommit(

2
src/applications/repository/worker/commitmessageparser/mercurial/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryMercurialCommitMessageParserWorker final class PhabricatorRepositoryMercurialCommitMessageParserWorker
extends PhabricatorRepositoryCommitMessageParserWorker { extends PhabricatorRepositoryCommitMessageParserWorker {
public function parseCommit( public function parseCommit(

4
src/applications/repository/worker/commitmessageparser/svn/PhabricatorRepositorySvnCommitMessageParserWorker.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositorySvnCommitMessageParserWorker final class PhabricatorRepositorySvnCommitMessageParserWorker
extends PhabricatorRepositoryCommitMessageParserWorker { extends PhabricatorRepositoryCommitMessageParserWorker {
public function parseCommit( public function parseCommit(

2
src/applications/repository/worker/herald/PhabricatorRepositoryCommitHeraldWorker.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryCommitHeraldWorker final class PhabricatorRepositoryCommitHeraldWorker
extends PhabricatorRepositoryCommitParserWorker { extends PhabricatorRepositoryCommitParserWorker {
public function parseCommit( public function parseCommit(

2
src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php
View file

@ -16,7 +16,7 @@
* limitations under the License. * limitations under the License.
*/ */
class PhabricatorRepositoryCommitOwnersWorker final class PhabricatorRepositoryCommitOwnersWorker
extends PhabricatorRepositoryCommitParserWorker { extends PhabricatorRepositoryCommitParserWorker {
protected function parseCommit( protected function parseCommit(

2
src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
View file

@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchDifferentialIndexer final class PhabricatorSearchDifferentialIndexer
extends PhabricatorSearchDocumentIndexer { extends PhabricatorSearchDocumentIndexer {
public static function indexRevision(DifferentialRevision $rev) { public static function indexRevision(DifferentialRevision $rev) {

4
src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchManiphestIndexer final class PhabricatorSearchManiphestIndexer
extends PhabricatorSearchDocumentIndexer { extends PhabricatorSearchDocumentIndexer {
public static function indexTask(ManiphestTask $task) { public static function indexTask(ManiphestTask $task) {

4
src/applications/search/index/indexer/phriction/PhabricatorSearchPhrictionIndexer.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchPhrictionIndexer final class PhabricatorSearchPhrictionIndexer
extends PhabricatorSearchDocumentIndexer { extends PhabricatorSearchDocumentIndexer {
public static function indexDocument(PhrictionDocument $document) { public static function indexDocument(PhrictionDocument $document) {

2
src/applications/search/index/indexer/repository/PhabricatorSearchCommitIndexer.php
View file

@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchCommitIndexer final class PhabricatorSearchCommitIndexer
extends PhabricatorSearchDocumentIndexer { extends PhabricatorSearchDocumentIndexer {
public static function indexCommit(PhabricatorRepositoryCommit $commit) { public static function indexCommit(PhabricatorRepositoryCommit $commit) {

4
src/applications/search/index/indexer/user/PhabricatorSearchUserIndexer.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchUserIndexer final class PhabricatorSearchUserIndexer
extends PhabricatorSearchDocumentIndexer { extends PhabricatorSearchDocumentIndexer {
public static function indexUser(PhabricatorUser $user) { public static function indexUser(PhabricatorUser $user) {

4
src/applications/search/storage/document/document/PhabricatorSearchDocument.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -19,7 +19,7 @@
/** /**
* @group search * @group search
*/ */
class PhabricatorSearchDocument extends PhabricatorSearchDAO { final class PhabricatorSearchDocument extends PhabricatorSearchDAO {
protected $phid; protected $phid;
protected $documentType; protected $documentType;

Some files were not shown because too many files have changed in this diff Show more