From d13906ff96548f5e1c8467ba9183e0222e89467a Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 7 Dec 2011 06:46:37 -0800
Subject: [PATCH] Add "tabindex" to Remarkup reference lists

Summary:
Prevent keyboard focus of these links so we don't disrupt tab order from
comments to "Submit".

Arguably I should make a "function" for this or something but there's nowhere to
really put it that makes any sense right now.

Test Plan: Verified Firefox skips these links in tab order.

Reviewers: fratrik, btrahan, jungejason

Reviewed By: fratrik

CC: aran, fratrik

Maniphest Tasks: T661

Differential Revision: 1180
---
 .../view/addcomment/DifferentialAddCommentView.php             | 3 ++-
 .../controller/taskdetail/ManiphestTaskDetailController.php    | 3 ++-
 .../phriction/controller/edit/PhrictionEditController.php      | 2 ++
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/applications/differential/view/addcomment/DifferentialAddCommentView.php b/src/applications/differential/view/addcomment/DifferentialAddCommentView.php
index 78d845a680..d0f40791c0 100644
--- a/src/applications/differential/view/addcomment/DifferentialAddCommentView.php
+++ b/src/applications/differential/view/addcomment/DifferentialAddCommentView.php
@@ -110,9 +110,10 @@ final class DifferentialAddCommentView extends AphrontView {
             array(
               'href' => PhabricatorEnv::getDoclink(
                 'article/Remarkup_Reference.html'),
+              'tabindex' => '-1',
               'target' => '_blank',
             ),
-            'Remarkup Reference')))
+            'Formatting Reference')))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue($is_serious ? 'Submit' : 'Clowncopterize'));
diff --git a/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
index c9dba18451..de455e3019 100644
--- a/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
@@ -412,9 +412,10 @@ class ManiphestTaskDetailController extends ManiphestController {
               'a',
               array(
                 'href' => $remarkup_href,
+                'tabindex' => '-1',
                 'target' => '_blank',
               ),
-              'Remarkup Syntax Reference'))
+              'Formatting Reference'))
           ->setID('transaction-comments'))
       ->appendChild(
         id(new AphrontFormDragAndDropUploadControl())
diff --git a/src/applications/phriction/controller/edit/PhrictionEditController.php b/src/applications/phriction/controller/edit/PhrictionEditController.php
index cfbbbd8dbd..452a036f16 100644
--- a/src/applications/phriction/controller/edit/PhrictionEditController.php
+++ b/src/applications/phriction/controller/edit/PhrictionEditController.php
@@ -129,6 +129,8 @@ class PhrictionEditController
       'a',
       array(
         'href' => PhabricatorEnv::getDoclink('article/Remarkup_Reference.html'),
+        'tabindex' => '-1',
+        'target' => '_blank',
       ),
       'Formatting Reference');