revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Don't use "--" to separate flags and arguments in "git ls-remote"

Browse source 
Summary: Fixes T12416. See that task for discussion. Slightly older versions of `git` do not appear to support use of `--` to separate flags and arguments.

Test Plan:
  - Ran `bin/repository update PHABX`.
  - In T12416, had a user with Git 2.1.4 confirm that `git ls-remote X` worked while `git ls-remote -- X` failed.
  - Read `git help ls-remote` to look for any kind of suspicious `--destroy-the-world` flags, didn't see any that made me uneasy.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T12416

Differential Revision: https://secure.phabricator.com/D17508
This commit is contained in:
epriestley 2017-03-18 17:29:44 -07:00
parent 688c120f9f
commit d19fc2335e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
View file

@ -392,8 +392,11 @@ final class PhabricatorRepositoryPullEngine
private function loadGitRemoteRefs(PhabricatorRepository $repository) { private function loadGitRemoteRefs(PhabricatorRepository $repository) {
$remote_envelope = $repository->getRemoteURIEnvelope(); $remote_envelope = $repository->getRemoteURIEnvelope();
// NOTE: "git ls-remote" does not support "--" until circa January 2016.
// See T12416. None of the flags to "ls-remote" appear dangerous, and
// other checks make it difficult to configure a suspicious remote URI.
list($stdout) = $repository->execxRemoteCommand( list($stdout) = $repository->execxRemoteCommand(
'ls-remote -- %P', 'ls-remote %P',
$remote_envelope); $remote_envelope);
$map = array(); $map = array();